Skip to content

Commit 4c597fb

Browse files
Yanqing Wanggregkh
authored andcommitted
driver: net: ethernet: mtk_star_emac: fix suspend/resume issue
[ Upstream commit ba99c62 ] Identify the cause of the suspend/resume hang: netif_carrier_off() is called during link state changes and becomes stuck while executing linkwatch_work(). To resolve this issue, call netif_device_detach() during the Ethernet suspend process to temporarily detach the network device from the kernel and prevent the suspend/resume hang. Fixes: 8c7bd5a ("net: ethernet: mtk-star-emac: new driver") Signed-off-by: Yanqing Wang <ot_yanqing.wang@mediatek.com> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> Signed-off-by: Biao Huang <biao.huang@mediatek.com> Link: https://patch.msgid.link/20250528075351.593068-1-macpaul.lin@mediatek.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent c762fc7 commit 4c597fb

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/ethernet/mediatek/mtk_star_emac.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1468,6 +1468,8 @@ static __maybe_unused int mtk_star_suspend(struct device *dev)
14681468
if (netif_running(ndev))
14691469
mtk_star_disable(ndev);
14701470

1471+
netif_device_detach(ndev);
1472+
14711473
clk_bulk_disable_unprepare(MTK_STAR_NCLKS, priv->clks);
14721474

14731475
return 0;
@@ -1492,6 +1494,8 @@ static __maybe_unused int mtk_star_resume(struct device *dev)
14921494
clk_bulk_disable_unprepare(MTK_STAR_NCLKS, priv->clks);
14931495
}
14941496

1497+
netif_device_attach(ndev);
1498+
14951499
return ret;
14961500
}
14971501

0 commit comments

Comments
 (0)