Skip to content

Commit 4aac453

Browse files
danielzgtgrafaeljw
authored andcommitted
ACPI: TAD: Add missing sysfs_remove_group() for ACPI_TAD_RT
Previously, after `rmmod acpi_tad`, `modprobe acpi_tad` would fail with this dmesg: sysfs: cannot create duplicate filename '/devices/platform/ACPI000E:00/time' Call Trace: <TASK> dump_stack_lvl+0x6c/0x90 dump_stack+0x10/0x20 sysfs_warn_dup+0x8b/0xa0 sysfs_add_file_mode_ns+0x122/0x130 internal_create_group+0x1dd/0x4c0 sysfs_create_group+0x13/0x20 acpi_tad_probe+0x147/0x1f0 [acpi_tad] platform_probe+0x42/0xb0 </TASK> acpi-tad ACPI000E:00: probe with driver acpi-tad failed with error -17 Fixes: 3230b2b ("ACPI: TAD: Add low-level support for real time capability") Signed-off-by: Daniel Tang <danielzgtg.opensource@gmail.com> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Link: https://patch.msgid.link/2881298.hMirdbgypa@daniel-desktop3 Cc: 5.2+ <stable@vger.kernel.org> # 5.2+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent b320789 commit 4aac453

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/acpi/acpi_tad.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -565,6 +565,9 @@ static void acpi_tad_remove(struct platform_device *pdev)
565565

566566
pm_runtime_get_sync(dev);
567567

568+
if (dd->capabilities & ACPI_TAD_RT)
569+
sysfs_remove_group(&dev->kobj, &acpi_tad_time_attr_group);
570+
568571
if (dd->capabilities & ACPI_TAD_DC_WAKE)
569572
sysfs_remove_group(&dev->kobj, &acpi_tad_dc_attr_group);
570573

0 commit comments

Comments
 (0)