Skip to content

Commit 456161e

Browse files
author
Ming Lei
committed
block: fix docs for freezing of queue limits updates
JIRA: https://issues.redhat.com/browse/RHEL-71345 Upstream Status: for-6.4/block commit 9c96821 Author: Christoph Hellwig <hch@lst.de> Date: Fri Jan 10 06:47:09 2025 +0100 block: fix docs for freezing of queue limits updates queue_limits_commit_update is the function that needs to operate on a frozen queue, not queue_limits_start_update. Update the kerneldoc comments to reflect that. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Ming Lei <ming.lei@redhat.com> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Reviewed-by: John Garry <john.g.garry@oracle.com> Link: https://lore.kernel.org/r/20250110054726.1499538-2-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Ming Lei <ming.lei@redhat.com>
1 parent 38786e7 commit 456161e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

block/blk-settings.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,8 @@ int blk_set_default_limits(struct queue_limits *lim)
389389
* @lim: limits to apply
390390
*
391391
* Apply the limits in @lim that were obtained from queue_limits_start_update()
392-
* and updated by the caller to @q.
392+
* and updated by the caller to @q. The caller must have frozen the queue or
393+
* ensure that there are no outstanding I/Os by other means.
393394
*
394395
* Returns 0 if successful, else a negative error code.
395396
*/

include/linux/blkdev.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -911,8 +911,7 @@ static inline unsigned int blk_boundary_sectors_left(sector_t offset,
911911
* the caller can modify. The caller must call queue_limits_commit_update()
912912
* to finish the update.
913913
*
914-
* Context: process context. The caller must have frozen the queue or ensured
915-
* that there is outstanding I/O by other means.
914+
* Context: process context.
916915
*/
917916
static inline struct queue_limits
918917
queue_limits_start_update(struct request_queue *q)

0 commit comments

Comments
 (0)