Skip to content

Commit 44a375e

Browse files
petrpavluRussell King (Oracle)
authored andcommitted
ARM: 9458/1: module: Ensure the override of module_arch_freeing_init()
The function module_arch_freeing_init() defined in arch/arm/kernel/module.c is supposed to override a weak function of the same name defined in kernel/module/main.c. However, the ARM override is also marked as weak, which means that selecting the correct function unnecessarily depends on the order in which object files with both functions are passed to the linker. Although it happens to be correct at the moment, the proper pattern is to make the ARM override a strong definition. Fixes: cdcb07e ("ARM: 8975/1: module: fix handling of unwind init sections") Signed-off-by: Petr Pavlu <petr.pavlu@suse.com> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
1 parent 8f5ae30 commit 44a375e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/arm/kernel/module.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ module_arch_cleanup(struct module *mod)
484484
#endif
485485
}
486486

487-
void __weak module_arch_freeing_init(struct module *mod)
487+
void module_arch_freeing_init(struct module *mod)
488488
{
489489
#ifdef CONFIG_ARM_UNWIND
490490
struct unwind_table *init = mod->arch.init_table;

0 commit comments

Comments
 (0)