tpm: Do not remap from ACPI resources again for Pluton TPM

JIRA: https://issues.redhat.com/browse/RHEL-102691

commit b1c1b98
Author: Valentin David <valentin.david@gmail.com>
Date: Mon, 10 Jul 2023 22:27:49 +0200

    For Pluton TPM devices, it was assumed that there was no ACPI memory
    regions. This is not true for ASUS ROG Ally. ACPI advertises
    0xfd500000-0xfd5fffff.

    Since remapping is already done in `crb_map_pluton`, remapping again
    in `crb_map_io` causes EBUSY error:

    [    3.510453] tpm_crb MSFT0101:00: can't request region for resource [mem 0xfd500000-0xfd5fffff]
    [    3.510463] tpm_crb: probe of MSFT0101:00 failed with error -16

    Cc: stable@vger.kernel.org # v6.3+
    Fixes: 4d27328 ("tpm_crb: Add support for CRB devices based on Pluton")
    Signed-off-by: Valentin David <valentin.david@gmail.com>
    Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
    Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

Signed-off-by: Marcin Juszkiewicz <mjuszkiewicz@redhat.com>

Author: hrw

drivers/char/tpm/tpm_crb.c

@@ -607,15 +607,18 @@ static int crb_map_io(struct acpi_device *device, struct crb_priv *priv,
 	u32 rsp_size;
 	int ret;
 
-	INIT_LIST_HEAD(&acpi_resource_list);
-	ret = acpi_dev_get_resources(device, &acpi_resource_list,
-				     crb_check_resource, iores_array);
-	if (ret < 0)
-		return ret;
-	acpi_dev_free_resource_list(&acpi_resource_list);
-
-	/* Pluton doesn't appear to define ACPI memory regions */
+	/*
+	 * Pluton sometimes does not define ACPI memory regions.
+	 * Mapping is then done in crb_map_pluton
+	 */
 	if (priv->sm != ACPI_TPM2_COMMAND_BUFFER_WITH_PLUTON) {
+		INIT_LIST_HEAD(&acpi_resource_list);
+		ret = acpi_dev_get_resources(device, &acpi_resource_list,
+					     crb_check_resource, iores_array);
+		if (ret < 0)
+			return ret;
+		acpi_dev_free_resource_list(&acpi_resource_list);
+
 		if (resource_type(iores_array) != IORESOURCE_MEM) {
 			dev_err(dev, FW_BUG "TPM2 ACPI table does not define a memory resource\n");
 			return -EINVAL;