Skip to content

Commit 3e4ebdc

Browse files
KanjiMonsterkuba-moo
authored andcommitted
net: dsa: b53: fix bcm63xx RGMII port link adjustment
BCM63XX's switch does not support MDIO scanning of external phys, so its MACs needs to be manually configured for autonegotiated link speeds. So b53_force_port_config() and b53_force_link() accordingly also when mode is MLO_AN_PHY for those ports. Fixes lower speeds than 1000/full on rgmii ports 4 - 7. This aligns the behaviour with the old bcm63xx_enetsw driver for those ports. Fixes: 967dd82 ("net: dsa: b53: Add support for Broadcom RoboSwitch") Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://patch.msgid.link/20251101132807.50419-3-jonas.gorski@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent b6a8a54 commit 3e4ebdc

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1602,8 +1602,11 @@ static void b53_phylink_mac_link_down(struct phylink_config *config,
16021602
struct b53_device *dev = dp->ds->priv;
16031603
int port = dp->index;
16041604

1605-
if (mode == MLO_AN_PHY)
1605+
if (mode == MLO_AN_PHY) {
1606+
if (is63xx(dev) && in_range(port, B53_63XX_RGMII0, 4))
1607+
b53_force_link(dev, port, false);
16061608
return;
1609+
}
16071610

16081611
if (mode == MLO_AN_FIXED) {
16091612
b53_force_link(dev, port, false);
@@ -1631,6 +1634,13 @@ static void b53_phylink_mac_link_up(struct phylink_config *config,
16311634
if (mode == MLO_AN_PHY) {
16321635
/* Re-negotiate EEE if it was enabled already */
16331636
p->eee_enabled = b53_eee_init(ds, port, phydev);
1637+
1638+
if (is63xx(dev) && in_range(port, B53_63XX_RGMII0, 4)) {
1639+
b53_force_port_config(dev, port, speed, duplex,
1640+
tx_pause, rx_pause);
1641+
b53_force_link(dev, port, true);
1642+
}
1643+
16341644
return;
16351645
}
16361646

0 commit comments

Comments
 (0)