Skip to content

Commit 3840427

Browse files
Akhilesh Patilvinodkoul
authored andcommitted
phy: ingenic: use core driver model helper to handle probe errors
Use core driver model helper dev_err_probe() defined at drivers/base/core.c in driver probe path to propagate errors. standardize and improve the code of deferred probe error handling using this helper for ingenic usb phy driver. Inspired by, commit a787e54 ("driver core: add device probe log helper") Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in> Cc: Andrzej Hajda <a.hajda@samsung.com> Link: https://lore.kernel.org/r/aIIMW971BYsIk4As@bhairav-test.ee.iitb.ac.in Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent ce48963 commit 3840427

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

drivers/phy/ingenic/phy-ingenic-usb.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -339,17 +339,13 @@ static int ingenic_usb_phy_probe(struct platform_device *pdev)
339339
priv->clk = devm_clk_get(dev, NULL);
340340
if (IS_ERR(priv->clk)) {
341341
err = PTR_ERR(priv->clk);
342-
if (err != -EPROBE_DEFER)
343-
dev_err(dev, "Failed to get clock\n");
344-
return err;
342+
return dev_err_probe(dev, err, "Failed to get clock\n");
345343
}
346344

347345
priv->vcc_supply = devm_regulator_get(dev, "vcc");
348346
if (IS_ERR(priv->vcc_supply)) {
349347
err = PTR_ERR(priv->vcc_supply);
350-
if (err != -EPROBE_DEFER)
351-
dev_err(dev, "Failed to get regulator\n");
352-
return err;
348+
return dev_err_probe(dev, err, "Failed to get regulator\n");
353349
}
354350

355351
priv->phy = devm_phy_create(dev, NULL, &ingenic_usb_phy_ops);

0 commit comments

Comments
 (0)