Skip to content

Commit 37e3567

Browse files
Yang Wangalexdeucher
authored andcommitted
drm/amd/pm: fix missing device_attr cleanup in amdgpu_pm_sysfs_init()
Use the correct label to complete all cleanup work. Fixes: 4d154b1 ("drm/amd/pm: Add support for DPM policies") Fixes: 25e82f2 ("drm/amd/pm: Add temperature metrics sysfs entry") Signed-off-by: Yang Wang <kevinyang.wang@amd.com> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit 4c4c138a1c86775c4d47e24f26357a1f8b64d0a3)
1 parent 90b75e1 commit 37e3567

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/amd/pm/amdgpu_pm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4724,14 +4724,14 @@ int amdgpu_pm_sysfs_init(struct amdgpu_device *adev)
47244724
ret = devm_device_add_group(adev->dev,
47254725
&amdgpu_pm_policy_attr_group);
47264726
if (ret)
4727-
goto err_out0;
4727+
goto err_out1;
47284728
}
47294729

47304730
if (amdgpu_dpm_is_temp_metrics_supported(adev, SMU_TEMP_METRIC_GPUBOARD)) {
47314731
ret = devm_device_add_group(adev->dev,
47324732
&amdgpu_board_attr_group);
47334733
if (ret)
4734-
goto err_out0;
4734+
goto err_out1;
47354735
if (amdgpu_pm_get_sensor_generic(adev, AMDGPU_PP_SENSOR_MAXNODEPOWERLIMIT,
47364736
(void *)&tmp) != -EOPNOTSUPP) {
47374737
sysfs_add_file_to_group(&adev->dev->kobj,

0 commit comments

Comments
 (0)