Skip to content

Commit 37c258c

Browse files
author
Myron Stowe
committed
Documentation: Fix pci=config_acs= example
JIRA: https://issues.redhat.com/browse/RHEL-72898 Upstream Status: b388fac commit b388fac Author: Akihiko Odaki <akihiko.odaki@daynix.com> Date: Sun Sep 15 10:36:58 2024 +0900 Documentation: Fix pci=config_acs= example The documentation currently says: config_acs= Format: <ACS flags>@<pci_dev>[; ...] Specify one or more PCI devices (in the format specified above) optionally prepended with flags and separated by semicolons. The respective capabilities will be enabled, disabled or unchanged based on what is specified in flags. (...) For example, pci=config_acs=10x would configure all devices that support ACS to enable P2P Request Redirect, disable Translation Blocking, and leave Source Validation unchanged from whatever power-up or firmware set it to. See the complete documentation at: https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html However, a flag specification always needs to be suffixed with "@" and a PCI valid device address, which is missing in this example. Also, to configure all devices that support ACS, the flag needs to be suffixed with "@pci:0:0", for the ACS support to be enabled. Fix the documentation so the example is correct. Link: https://lore.kernel.org/r/20240915-acs-v1-1-b9ee536ee9bd@daynix.com Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> [kwilczynski: commit log] Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Signed-off-by: Myron Stowe <mstowe@redhat.com>
1 parent 302e852 commit 37c258c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Documentation/admin-guide/kernel-parameters.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4545,7 +4545,7 @@
45454545
'1' – force enabled
45464546
'x' – unchanged
45474547
For example,
4548-
pci=config_acs=10x
4548+
pci=config_acs=10x@pci:0:0
45494549
would configure all devices that support
45504550
ACS to enable P2P Request Redirect, disable
45514551
Translation Blocking, and leave Source

0 commit comments

Comments
 (0)