Skip to content

Commit 2c8ca35

Browse files
Kalesh APgregkh
authored andcommitted
bnxt_en: Fix a possible memory leak in bnxt_ptp_init
[ Upstream commit deb8eb3 ] In bnxt_ptp_init(), when ptp_clock_register() fails, the driver is not freeing the memory allocated for ptp_info->pin_config. Fix it to unconditionally free ptp_info->pin_config in bnxt_ptp_free(). Fixes: caf3eed ("bnxt_en: 1PPS support for 5750X family chips") Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Link: https://patch.msgid.link/20251104005700.542174-3-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent ae81117 commit 2c8ca35

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,9 +1040,9 @@ static void bnxt_ptp_free(struct bnxt *bp)
10401040
if (ptp->ptp_clock) {
10411041
ptp_clock_unregister(ptp->ptp_clock);
10421042
ptp->ptp_clock = NULL;
1043-
kfree(ptp->ptp_info.pin_config);
1044-
ptp->ptp_info.pin_config = NULL;
10451043
}
1044+
kfree(ptp->ptp_info.pin_config);
1045+
ptp->ptp_info.pin_config = NULL;
10461046
}
10471047

10481048
int bnxt_ptp_init(struct bnxt *bp)

0 commit comments

Comments
 (0)