Commit 2743cf7
powerpc, ocxl: Fix extraction of struct xive_irq_data
Commit cc0cc23 ("powerpc/xive: Untangle xive from child interrupt
controller drivers") changed xive_irq_data to be stashed to chip_data
instead of handler_data. However, multiple places are still attempting to
read xive_irq_data from handler_data and get a NULL pointer deference bug.
Update them to read xive_irq_data from chip_data.
Non-XIVE files which touch xive_irq_data seem quite strange to me,
especially the ocxl driver. I think there ought to be an alternative
platform-independent solution, instead of touching XIVE's data directly.
Therefore, I think this whole thing should be cleaned up. But perhaps I
just misunderstand something. In any case, this cleanup would not be
trivial; for now, just get things working again.
Fixes: cc0cc23 ("powerpc/xive: Untangle xive from child interrupt controller drivers")
Reported-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Closes: https://lore.kernel.org/linuxppc-dev/68e48df8.170a0220.4b4b0.217d@mx.google.com/
Signed-off-by: Nam Cao <namcao@linutronix.de>
Reviewed-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com> # ocxl
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20251008081359.1382699-1-namcao@linutronix.de1 parent ef3e73a commit 2743cf7
File tree
4 files changed
+7
-11
lines changed- arch/powerpc
- kvm
- platforms/powernv
- sysdev/xive
- drivers/misc/ocxl
4 files changed
+7
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
916 | 916 | | |
917 | 917 | | |
918 | 918 | | |
919 | | - | |
920 | | - | |
| 919 | + | |
921 | 920 | | |
922 | 921 | | |
923 | 922 | | |
| |||
1612 | 1611 | | |
1613 | 1612 | | |
1614 | 1613 | | |
1615 | | - | |
| 1614 | + | |
1616 | 1615 | | |
1617 | 1616 | | |
1618 | 1617 | | |
| |||
1787 | 1786 | | |
1788 | 1787 | | |
1789 | 1788 | | |
1790 | | - | |
1791 | | - | |
| 1789 | + | |
1792 | 1790 | | |
1793 | 1791 | | |
1794 | 1792 | | |
| |||
2827 | 2825 | | |
2828 | 2826 | | |
2829 | 2827 | | |
2830 | | - | |
2831 | | - | |
2832 | | - | |
| 2828 | + | |
2833 | 2829 | | |
2834 | 2830 | | |
2835 | 2831 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1580 | 1580 | | |
1581 | 1581 | | |
1582 | 1582 | | |
1583 | | - | |
| 1583 | + | |
1584 | 1584 | | |
1585 | 1585 | | |
1586 | 1586 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
| 206 | + | |
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
| |||
0 commit comments