scsi: sg: Remove unnecessary NULL check before unregister_sysctl_table()

Chen Ni · martinkpetersen · commit 25c2758e6e72 · 2025-05-20T21:59:44.000-04:00
unregister_sysctl_table() checks for NULL pointers internally. Remove unneeded NULL check here. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Link: https://lore.kernel.org/r/20250514032845.2317700-1-nichen@iscas.ac.cn Reviewed-by: John Garry <john.g.garry@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
@@ -1658,8 +1658,7 @@ static void register_sg_sysctls(void)
 
 static void unregister_sg_sysctls(void)
 {
-	if (hdr)
-		unregister_sysctl_table(hdr);
+	unregister_sysctl_table(hdr);
 }
 #else
 #define register_sg_sysctls() do { } while (0)

Original file line number	Diff line number	Diff line change
`@@ -1658,8 +1658,7 @@ static void register_sg_sysctls(void)`
`1658`	`1658`
`1659`	`1659`	`static void unregister_sg_sysctls(void)`
`1660`	`1660`	`{`
`1661`		`- if (hdr)`
`1662`		`- unregister_sysctl_table(hdr);`
	`1661`	`+ unregister_sysctl_table(hdr);`
`1663`	`1662`	`}`
`1664`	`1663`	`#else`
`1665`	`1664`	`#define register_sg_sysctls() do { } while (0)`