Skip to content

Commit 2319f9d

Browse files
covanambrauner
authored andcommitted
selftests/coredump: Remove the read() that fails the test
Resolve a conflict between commit 6a68d28 ("selftests/coredump: Fix "socket_detect_userspace_client" test failure") and commit 994dc26 ("selftests/coredump: fix build") The first commit adds a read() to wait for write() from another thread to finish. But the second commit removes the write(). Now that the two commits are in the same tree, the read() now gets EOF and the test fails. Remove this read() so that the test passes. Signed-off-by: Nam Cao <namcao@linutronix.de> Link: https://lore.kernel.org/20250811074957.4079616-1-namcao@linutronix.de Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 542ede0 commit 2319f9d

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

tools/testing/selftests/coredump/stackdump_test.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -446,9 +446,6 @@ TEST_F(coredump, socket_detect_userspace_client)
446446
if (info.coredump_mask & PIDFD_COREDUMPED)
447447
goto out;
448448

449-
if (read(fd_coredump, &c, 1) < 1)
450-
goto out;
451-
452449
exit_code = EXIT_SUCCESS;
453450
out:
454451
if (fd_peer_pidfd >= 0)

0 commit comments

Comments
 (0)