Skip to content

Commit 21aa3a8

Browse files
committed
x86/module: enable ROX caches for module text on 64 bit
jira LE-4694 Rebuild_History Non-Buildable kernel-6.12.0-55.43.1.el10_0 commit-author Mike Rapoport (Microsoft) <rppt@kernel.org> commit 5185e7f Enable execmem's cache of PMD_SIZE'ed pages mapped as ROX for module text allocations on 64 bit. Link: https://lkml.kernel.org/r/20241023162711.2579610-9-rppt@kernel.org Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> Tested-by: kdevops <kdevops@lists.linux.dev> Cc: Andreas Larsson <andreas@gaisler.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Ard Biesheuvel <ardb@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Borislav Petkov (AMD) <bp@alien8.de> Cc: Brian Cain <bcain@quicinc.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Christophe Leroy <christophe.leroy@csgroup.eu> Cc: Christoph Hellwig <hch@lst.de> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Dinh Nguyen <dinguyen@kernel.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Guo Ren <guoren@kernel.org> Cc: Helge Deller <deller@gmx.de> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Kent Overstreet <kent.overstreet@linux.dev> Cc: Liam R. Howlett <Liam.Howlett@Oracle.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Masami Hiramatsu (Google) <mhiramat@kernel.org> Cc: Matt Turner <mattst88@gmail.com> Cc: Max Filippov <jcmvbkbc@gmail.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Michal Simek <monstr@monstr.eu> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Richard Weinberger <richard@nod.at> Cc: Russell King <linux@armlinux.org.uk> Cc: Song Liu <song@kernel.org> Cc: Stafford Horne <shorne@gmail.com> Cc: Steven Rostedt (Google) <rostedt@goodmis.org> Cc: Suren Baghdasaryan <surenb@google.com> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Uladzislau Rezki (Sony) <urezki@gmail.com> Cc: Vineet Gupta <vgupta@kernel.org> Cc: Will Deacon <will@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> (cherry picked from commit 5185e7f) Signed-off-by: Jonathan Maple <jmaple@ciq.com>
1 parent 1bdf654 commit 21aa3a8

File tree

2 files changed

+37
-1
lines changed

2 files changed

+37
-1
lines changed

arch/x86/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ config X86
8383
select ARCH_HAS_DMA_OPS if GART_IOMMU || XEN
8484
select ARCH_HAS_EARLY_DEBUG if KGDB
8585
select ARCH_HAS_ELF_RANDOMIZE
86+
select ARCH_HAS_EXECMEM_ROX if X86_64
8687
select ARCH_HAS_FAST_MULTIPLIER
8788
select ARCH_HAS_FORTIFY_SOURCE
8889
select ARCH_HAS_GCOV_PROFILE_ALL

arch/x86/mm/init.c

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1053,18 +1053,53 @@ unsigned long arch_max_swapfile_size(void)
10531053
#ifdef CONFIG_EXECMEM
10541054
static struct execmem_info execmem_info __ro_after_init;
10551055

1056+
#ifdef CONFIG_ARCH_HAS_EXECMEM_ROX
1057+
void execmem_fill_trapping_insns(void *ptr, size_t size, bool writeable)
1058+
{
1059+
/* fill memory with INT3 instructions */
1060+
if (writeable)
1061+
memset(ptr, INT3_INSN_OPCODE, size);
1062+
else
1063+
text_poke_set(ptr, INT3_INSN_OPCODE, size);
1064+
}
1065+
#endif
1066+
10561067
struct execmem_info __init *execmem_arch_setup(void)
10571068
{
10581069
unsigned long start, offset = 0;
1070+
enum execmem_range_flags flags;
1071+
pgprot_t pgprot;
10591072

10601073
if (kaslr_enabled())
10611074
offset = get_random_u32_inclusive(1, 1024) * PAGE_SIZE;
10621075

10631076
start = MODULES_VADDR + offset;
10641077

1078+
if (IS_ENABLED(CONFIG_ARCH_HAS_EXECMEM_ROX)) {
1079+
pgprot = PAGE_KERNEL_ROX;
1080+
flags = EXECMEM_KASAN_SHADOW | EXECMEM_ROX_CACHE;
1081+
} else {
1082+
pgprot = PAGE_KERNEL;
1083+
flags = EXECMEM_KASAN_SHADOW;
1084+
}
1085+
10651086
execmem_info = (struct execmem_info){
10661087
.ranges = {
1067-
[EXECMEM_DEFAULT] = {
1088+
[EXECMEM_MODULE_TEXT] = {
1089+
.flags = flags,
1090+
.start = start,
1091+
.end = MODULES_END,
1092+
.pgprot = pgprot,
1093+
.alignment = MODULE_ALIGN,
1094+
},
1095+
[EXECMEM_KPROBES ... EXECMEM_BPF] = {
1096+
.flags = EXECMEM_KASAN_SHADOW,
1097+
.start = start,
1098+
.end = MODULES_END,
1099+
.pgprot = PAGE_KERNEL,
1100+
.alignment = MODULE_ALIGN,
1101+
},
1102+
[EXECMEM_MODULE_DATA] = {
10681103
.flags = EXECMEM_KASAN_SHADOW,
10691104
.start = start,
10701105
.end = MODULES_END,

0 commit comments

Comments
 (0)