Skip to content

Commit 211fb1b

Browse files
committed
netfilter: nf_tables: fix kdoc warnings after gc rework
jira VUlN-597 subsystem-sync netfilter:nf_tables 4.18.0-534 commit-author Florian Westphal <fw@strlen.de> commit 08713cb Jakub Kicinski says: We've got some new kdoc warnings here: net/netfilter/nft_set_pipapo.c:1557: warning: Function parameter or member '_set' not described in 'pipapo_gc' net/netfilter/nft_set_pipapo.c:1557: warning: Excess function parameter 'set' description in 'pipapo_gc' include/net/netfilter/nf_tables.h:577: warning: Function parameter or member 'dead' not described in 'nft_set' Fixes: 5f68718 ("netfilter: nf_tables: GC transaction API to avoid race with control plane") Fixes: f6c383b ("netfilter: nf_tables: adapt set backend to use GC transaction API") Reported-by: Jakub Kicinski <kuba@kernel.org> Closes: https://lore.kernel.org/netdev/20230810104638.746e46f1@kernel.org/ Signed-off-by: Florian Westphal <fw@strlen.de> (cherry picked from commit 08713cb) Signed-off-by: Greg Rose <g.v.rose@ciq.com> (cherry picked from commit ddcae6925219c35588313d4f84e103e8a885e457) Signed-off-by: Greg Rose <g.v.rose@ciq.com>
1 parent 2b477ec commit 211fb1b

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

include/net/netfilter/nf_tables.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,7 @@ struct nft_set_elem_expr {
467467
* @expr: stateful expression
468468
* @ops: set ops
469469
* @flags: set flags
470+
* @dead: set will be freed, never cleared
470471
* @genmask: generation mask
471472
* @klen: key length
472473
* @dlen: data length

net/netfilter/nft_set_pipapo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1449,7 +1449,7 @@ static void nft_pipapo_gc_deactivate(struct net *net, struct nft_set *set,
14491449

14501450
/**
14511451
* pipapo_gc() - Drop expired entries from set, destroy start and end elements
1452-
* @set: nftables API set representation
1452+
* @_set: nftables API set representation
14531453
* @m: Matching data
14541454
*/
14551455
static void pipapo_gc(const struct nft_set *_set, struct nft_pipapo_match *m)

0 commit comments

Comments
 (0)