Skip to content

Commit 1e8f75c

Browse files
committed
ACPI: pfr_update: Fix the driver update version check
JIRA: https://issues.redhat.com/browse/RHEL-114092 commit 8151320 Author: Chen Yu <yu.c.chen@intel.com> Date: Wed, 20 Aug 2025 15:30:36 +0000 The security-version-number check should be used rather than the runtime version check for driver updates. Otherwise, the firmware update would fail when the update binary had a lower runtime version number than the current one. Fixes: 0db89fa ("ACPI: Introduce Platform Firmware Runtime Update device driver") Cc: 5.17+ <stable@vger.kernel.org> # 5.17+ Reported-by: "Govindarajulu, Hariganesh" <hariganesh.govindarajulu@intel.com> Signed-off-by: Chen Yu <yu.c.chen@intel.com> Link: https://patch.msgid.link/20250722143233.3970607-1-yu.c.chen@intel.com [ rjw: Changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
1 parent c4a0965 commit 1e8f75c

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

drivers/acpi/pfr_update.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ static bool applicable_image(const void *data, struct pfru_update_cap_info *cap,
329329
if (type == PFRU_CODE_INJECT_TYPE)
330330
return payload_hdr->rt_ver >= cap->code_rt_version;
331331

332-
return payload_hdr->rt_ver >= cap->drv_rt_version;
332+
return payload_hdr->svn_ver >= cap->drv_svn;
333333
}
334334

335335
static void print_update_debug_info(struct pfru_updated_result *result,

include/uapi/linux/pfrut.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ struct pfru_payload_hdr {
8989
__u32 hw_ver;
9090
__u32 rt_ver;
9191
__u8 platform_id[16];
92+
__u32 svn_ver;
9293
};
9394

9495
enum pfru_dsm_status {

0 commit comments

Comments
 (0)