Skip to content

Commit 180acd5

Browse files
author
Shruti Parab
committed
bnxt_en: Add missing skb_mark_for_recycle() in bnxt_rx_vlan()
JIRA: https://issues.redhat.com/browse/RHEL-76565 commit a63db07 Author: Somnath Kotur <somnath.kotur@broadcom.com> Date: Mon Apr 28 15:58:58 2025 -0700 bnxt_en: Add missing skb_mark_for_recycle() in bnxt_rx_vlan() If bnxt_rx_vlan() fails because the VLAN protocol ID is invalid, the SKB is freed but we're missing the call to recycle it. This may cause the warning: "page_pool_release_retry() stalled pool shutdown" Add the missing skb_mark_for_recycle() in bnxt_rx_vlan(). Fixes: 86b0550 ("bnxt_en: Use the unified RX page pool buffers for XDP and non-XDP") Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Shruti Parab <shruti.parab@broadcom.com>
1 parent 47ecf27 commit 180acd5

File tree

1 file changed

+1
-0
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+1
-0
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2011,6 +2011,7 @@ static struct sk_buff *bnxt_rx_vlan(struct sk_buff *skb, u8 cmp_type,
20112011
}
20122012
return skb;
20132013
vlan_err:
2014+
skb_mark_for_recycle(skb);
20142015
dev_kfree_skb(skb);
20152016
return NULL;
20162017
}

0 commit comments

Comments
 (0)