Skip to content

Commit 174adf9

Browse files
author
Izabela Bakollari
committed
r8169: disable RTL8126 ZRX-DC timeout
JIRA: https://issues.redhat.com/browse/RHEL-89041 JIRA: https://issues.redhat.com/browse/RHEL-84976 commit b48688e Author: ChunHao Lin <hau@realtek.com> Date: Tue Mar 18 16:37:21 2025 +0800 r8169: disable RTL8126 ZRX-DC timeout Disable it due to it dose not meet ZRX-DC specification. If it is enabled, device will exit L1 substate every 100ms. Disable it for saving more power in L1 substate. Signed-off-by: ChunHao Lin <hau@realtek.com> Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com> Link: https://patch.msgid.link/20250318083721.4127-3-hau@realtek.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Izabela Bakollari <ibakolla@redhat.com>
1 parent 72d2aef commit 174adf9

File tree

1 file changed

+27
-0
lines changed

1 file changed

+27
-0
lines changed

drivers/net/ethernet/realtek/r8169_main.c

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2861,6 +2861,32 @@ static u32 rtl_csi_read(struct rtl8169_private *tp, int addr)
28612861
RTL_R32(tp, CSIDR) : ~0;
28622862
}
28632863

2864+
static void rtl_disable_zrxdc_timeout(struct rtl8169_private *tp)
2865+
{
2866+
struct pci_dev *pdev = tp->pci_dev;
2867+
u32 csi;
2868+
int rc;
2869+
u8 val;
2870+
2871+
#define RTL_GEN3_RELATED_OFF 0x0890
2872+
#define RTL_GEN3_ZRXDC_NONCOMPL 0x1
2873+
if (pdev->cfg_size > RTL_GEN3_RELATED_OFF) {
2874+
rc = pci_read_config_byte(pdev, RTL_GEN3_RELATED_OFF, &val);
2875+
if (rc == PCIBIOS_SUCCESSFUL) {
2876+
val &= ~RTL_GEN3_ZRXDC_NONCOMPL;
2877+
rc = pci_write_config_byte(pdev, RTL_GEN3_RELATED_OFF,
2878+
val);
2879+
if (rc == PCIBIOS_SUCCESSFUL)
2880+
return;
2881+
}
2882+
}
2883+
2884+
netdev_notice_once(tp->dev,
2885+
"No native access to PCI extended config space, falling back to CSI\n");
2886+
csi = rtl_csi_read(tp, RTL_GEN3_RELATED_OFF);
2887+
rtl_csi_write(tp, RTL_GEN3_RELATED_OFF, csi & ~RTL_GEN3_ZRXDC_NONCOMPL);
2888+
}
2889+
28642890
static void rtl_set_aspm_entry_latency(struct rtl8169_private *tp, u8 val)
28652891
{
28662892
struct pci_dev *pdev = tp->pci_dev;
@@ -3912,6 +3938,7 @@ static void rtl_hw_start_8125d(struct rtl8169_private *tp)
39123938

39133939
static void rtl_hw_start_8126a(struct rtl8169_private *tp)
39143940
{
3941+
rtl_disable_zrxdc_timeout(tp);
39153942
rtl_set_def_aspm_entry_latency(tp);
39163943
rtl_hw_start_8125_common(tp);
39173944
}

0 commit comments

Comments
 (0)