idpf: remove dealloc vector msg err in idpf_intr_rel

JIRA: https://issues.redhat.com/browse/RHEL-29553

commit 6009e63
Author: Alan Brady <alan.brady@intel.com>
Date:   Thu Feb 22 11:04:41 2024 -0800

    idpf: remove dealloc vector msg err in idpf_intr_rel

    This error message is at best not really helpful and at worst
    misleading. If we're here in idpf_intr_rel we're likely trying to do
    remove or reset. If we're in reset, this message will fail because we
    lose the virtchnl on reset and HW is going to clean up those resources
    regardless in that case. If we're in remove and we get an error here,
    we're going to reset the device at the end of remove anyway so not a big
    deal. Just remove this message it's not useful.

    Tested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
    Signed-off-by: Alan Brady <alan.brady@intel.com>
    Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>

Author: michich

drivers/net/ethernet/intel/idpf/idpf_lib.c

@@ -79,19 +79,12 @@ static void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter)
  */
 void idpf_intr_rel(struct idpf_adapter *adapter)
 {
-	int err;
-
 	if (!adapter->msix_entries)
 		return;
 
 	idpf_mb_intr_rel_irq(adapter);
 	pci_free_irq_vectors(adapter->pdev);
-
-	err = idpf_send_dealloc_vectors_msg(adapter);
-	if (err)
-		dev_err(&adapter->pdev->dev,
-			"Failed to deallocate vectors: %d\n", err);
-
+	idpf_send_dealloc_vectors_msg(adapter);
 	idpf_deinit_vector_stack(adapter);
 	kfree(adapter->msix_entries);
 	adapter->msix_entries = NULL;