Skip to content

Commit 0d6c356

Browse files
Isaac J. Manjarresakpm00
authored andcommitted
mm/mm_init: fix hash table order logging in alloc_large_system_hash()
When emitting the order of the allocation for a hash table, alloc_large_system_hash() unconditionally subtracts PAGE_SHIFT from log base 2 of the allocation size. This is not correct if the allocation size is smaller than a page, and yields a negative value for the order as seen below: TCP established hash table entries: 32 (order: -4, 256 bytes, linear) TCP bind hash table entries: 32 (order: -2, 1024 bytes, linear) Use get_order() to compute the order when emitting the hash table information to correctly handle cases where the allocation size is smaller than a page: TCP established hash table entries: 32 (order: 0, 256 bytes, linear) TCP bind hash table entries: 32 (order: 0, 1024 bytes, linear) Link: https://lkml.kernel.org/r/20251028191020.413002-1-isaacmanjarres@google.com Fixes: 1da177e ("Linux-2.6.12-rc2") Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Reviewed-by: David Hildenbrand <david@redhat.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent fa04f5b commit 0d6c356

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mm/mm_init.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2469,7 +2469,7 @@ void *__init alloc_large_system_hash(const char *tablename,
24692469
panic("Failed to allocate %s hash table\n", tablename);
24702470

24712471
pr_info("%s hash table entries: %ld (order: %d, %lu bytes, %s)\n",
2472-
tablename, 1UL << log2qty, ilog2(size) - PAGE_SHIFT, size,
2472+
tablename, 1UL << log2qty, get_order(size), size,
24732473
virt ? (huge ? "vmalloc hugepage" : "vmalloc") : "linear");
24742474

24752475
if (_hash_shift)

0 commit comments

Comments
 (0)