Skip to content

Commit 09310cf

Browse files
Dan Carpenterkuba-moo
authored andcommitted
rtnetlink: fix error code in rtnl_newlink()
If rtnl_get_peer_net() fails, then propagate the error code. Don't return success. Fixes: 4832756 ("rtnetlink: fix double call of rtnl_link_get_net_ifla()") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Link: https://patch.msgid.link/a2d20cd4-387a-4475-887c-bb7d0e88e25a@stanley.mountain Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ab80e71 commit 09310cf

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

net/core/rtnetlink.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3972,8 +3972,10 @@ static int rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh,
39723972

39733973
if (ops->peer_type) {
39743974
peer_net = rtnl_get_peer_net(ops, data, extack);
3975-
if (IS_ERR(peer_net))
3975+
if (IS_ERR(peer_net)) {
3976+
ret = PTR_ERR(peer_net);
39763977
goto put_ops;
3978+
}
39773979
if (peer_net)
39783980
rtnl_nets_add(&rtnl_nets, peer_net);
39793981
}

0 commit comments

Comments
 (0)