Skip to content

Commit 06195ee

Browse files
mitaakpm00
authored andcommitted
mm/damon/sysfs: do not ignore callback's return value in damon_sysfs_damon_call()
The callback return value is ignored in damon_sysfs_damon_call(), which means that it is not possible to detect invalid user input when writing commands such as 'commit' to /sys/kernel/mm/damon/admin/kdamonds/<K>/state. Fix it. Link: https://lkml.kernel.org/r/20250920132546.5822-1-akinobu.mita@gmail.com Fixes: f64539d ("mm/damon/sysfs: use damon_call() for update_schemes_stats") Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Reviewed-by: SeongJae Park <sj@kernel.org> Cc: <stable@vger.kernel.org> [6.14+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 87e1c7c commit 06195ee

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

mm/damon/sysfs.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1592,12 +1592,14 @@ static int damon_sysfs_damon_call(int (*fn)(void *data),
15921592
struct damon_sysfs_kdamond *kdamond)
15931593
{
15941594
struct damon_call_control call_control = {};
1595+
int err;
15951596

15961597
if (!kdamond->damon_ctx)
15971598
return -EINVAL;
15981599
call_control.fn = fn;
15991600
call_control.data = kdamond;
1600-
return damon_call(kdamond->damon_ctx, &call_control);
1601+
err = damon_call(kdamond->damon_ctx, &call_control);
1602+
return err ? err : call_control.return_code;
16011603
}
16021604

16031605
struct damon_sysfs_schemes_walk_data {

0 commit comments

Comments
 (0)