Skip to content

Commit 034af00

Browse files
committed
platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called twice on init_bios_attributes() failure
jira LE-3064 Rebuild_History Non-Buildable kernel-4.18.0-553.53.1.el8_10 commit-author Hans de Goede <hdegoede@redhat.com> commit f4c4e9a All calls of init_bios_attributes() will result in a goto fail_create_group if they fail, which calls release_attributes_data(). So there is no need to call release_attributes_data() from init_bios_attributes() on failure itself. Fixes: e8a60aa ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems") Cc: Divya Bharathi <Divya_Bharathi@dell.com> Cc: Mario Limonciello <mario.limonciello@dell.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20210321115901.35072-5-hdegoede@redhat.com (cherry picked from commit f4c4e9a) Signed-off-by: Jonathan Maple <jmaple@ciq.com>
1 parent c9bcfcc commit 034af00

File tree

1 file changed

+0
-1
lines changed
  • drivers/platform/x86/dell-wmi-sysman

1 file changed

+0
-1
lines changed

drivers/platform/x86/dell-wmi-sysman/sysman.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,6 @@ static int init_bios_attributes(int attr_type, const char *guid)
489489

490490
err_attr_init:
491491
mutex_unlock(&wmi_priv.mutex);
492-
release_attributes_data();
493492
kfree(obj);
494493
return retval;
495494
}

0 commit comments

Comments
 (0)