Skip to content

Commit 02fda9f

Browse files
author
Ming Lei
committed
block: Make REQ_OP_ZONE_FINISH a write operation
JIRA: https://issues.redhat.com/browse/RHEL-97177 commit 3f66ccb Author: Damien Le Moal <dlemoal@kernel.org> Date: Wed Jun 25 18:33:23 2025 +0900 block: Make REQ_OP_ZONE_FINISH a write operation REQ_OP_ZONE_FINISH is defined as "12", which makes op_is_write(REQ_OP_ZONE_FINISH) return false, despite the fact that a zone finish operation is an operation that modifies a zone (transition it to full) and so should be considered as a write operation (albeit one that does not transfer any data to the device). Fix this by redefining REQ_OP_ZONE_FINISH to be an odd number (13), and redefine REQ_OP_ZONE_RESET and REQ_OP_ZONE_RESET_ALL using sequential odd numbers from that new value. Fixes: 6c1b1da ("block: add zone open, close and finish operations") Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/r/20250625093327.548866-2-dlemoal@kernel.org Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Ming Lei <ming.lei@redhat.com>
1 parent e3a7126 commit 02fda9f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

include/linux/blk_types.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,11 +350,11 @@ enum req_op {
350350
/* Close a zone */
351351
REQ_OP_ZONE_CLOSE = (__force blk_opf_t)11,
352352
/* Transition a zone to full */
353-
REQ_OP_ZONE_FINISH = (__force blk_opf_t)12,
353+
REQ_OP_ZONE_FINISH = (__force blk_opf_t)13,
354354
/* reset a zone write pointer */
355-
REQ_OP_ZONE_RESET = (__force blk_opf_t)13,
355+
REQ_OP_ZONE_RESET = (__force blk_opf_t)15,
356356
/* reset all the zone present on the device */
357-
REQ_OP_ZONE_RESET_ALL = (__force blk_opf_t)15,
357+
REQ_OP_ZONE_RESET_ALL = (__force blk_opf_t)17,
358358

359359
/* Driver private requests */
360360
REQ_OP_DRV_IN = (__force blk_opf_t)34,

0 commit comments

Comments
 (0)