Skip to content

Commit 02d1fa9

Browse files
author
Chris von Recklinghausen
committed
mm/page_table_check: fix crash on ZONE_DEVICE
JIRA: https://issues.redhat.com/browse/RHEL-48052 CVE: CVE-2024-40948 commit 8bb592c Author: Peter Xu <peterx@redhat.com> Date: Wed Jun 5 17:21:46 2024 -0400 mm/page_table_check: fix crash on ZONE_DEVICE Not all pages may apply to pgtable check. One example is ZONE_DEVICE pages: they map PFNs directly, and they don't allocate page_ext at all even if there's struct page around. One may reference devm_memremap_pages(). When both ZONE_DEVICE and page-table-check enabled, then try to map some dax memories, one can trigger kernel bug constantly now when the kernel was trying to inject some pfn maps on the dax device: kernel BUG at mm/page_table_check.c:55! While it's pretty legal to use set_pxx_at() for ZONE_DEVICE pages for page fault resolutions, skip all the checks if page_ext doesn't even exist in pgtable checker, which applies to ZONE_DEVICE but maybe more. Link: https://lkml.kernel.org/r/20240605212146.994486-1-peterx@redhat.com Fixes: df4e817 ("mm: page table check") Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com> Reviewed-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Alistair Popple <apopple@nvidia.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Chris von Recklinghausen <crecklin@redhat.com>
1 parent 53176f5 commit 02d1fa9

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

mm/page_table_check.c

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ static void page_table_check_clear(struct mm_struct *mm, unsigned long addr,
7272
page = pfn_to_page(pfn);
7373
page_ext = page_ext_get(page);
7474

75+
if (!page_ext)
76+
return;
77+
7578
BUG_ON(PageSlab(page));
7679
anon = PageAnon(page);
7780

@@ -110,6 +113,9 @@ static void page_table_check_set(struct mm_struct *mm, unsigned long addr,
110113
page = pfn_to_page(pfn);
111114
page_ext = page_ext_get(page);
112115

116+
if (!page_ext)
117+
return;
118+
113119
BUG_ON(PageSlab(page));
114120
anon = PageAnon(page);
115121

@@ -140,7 +146,10 @@ void __page_table_check_zero(struct page *page, unsigned int order)
140146
BUG_ON(PageSlab(page));
141147

142148
page_ext = page_ext_get(page);
143-
BUG_ON(!page_ext);
149+
150+
if (!page_ext)
151+
return;
152+
144153
for (i = 0; i < (1ul << order); i++) {
145154
struct page_table_check *ptc = get_page_table_check(page_ext);
146155

0 commit comments

Comments
 (0)