Skip to content

Commit 001750b

Browse files
committed
x86/mce: Don't remove sysfs if thresholding sysfs init fails
JIRA: https://issues.redhat.com/browse/RHEL-118444 commit 4c113a5 Author: Yazen Ghannam <yazen.ghannam@amd.com> Date: Tue Jun 24 14:15:56 2025 +0000 x86/mce: Don't remove sysfs if thresholding sysfs init fails Currently, the MCE subsystem sysfs interface will be removed if the thresholding sysfs interface fails to be created. A common failure is due to new MCA bank types that are not recognized and don't have a short name set. The MCA thresholding feature is optional and should not break the common MCE sysfs interface. Also, new MCA bank types are occasionally introduced, and updates will be needed to recognize them. But likewise, this should not break the common sysfs interface. Keep the MCE sysfs interface regardless of the status of the thresholding sysfs interface. Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com> Reviewed-by: Tony Luck <tony.luck@intel.com> Tested-by: Tony Luck <tony.luck@intel.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/20250624-wip-mca-updates-v4-1-236dd74f645f@amd.com Signed-off-by: David Arcari <darcari@redhat.com>
1 parent c76db5d commit 001750b

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

arch/x86/kernel/cpu/mce/core.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2775,15 +2775,9 @@ static int mce_cpu_dead(unsigned int cpu)
27752775
static int mce_cpu_online(unsigned int cpu)
27762776
{
27772777
struct timer_list *t = this_cpu_ptr(&mce_timer);
2778-
int ret;
27792778

27802779
mce_device_create(cpu);
2781-
2782-
ret = mce_threshold_create_device(cpu);
2783-
if (ret) {
2784-
mce_device_remove(cpu);
2785-
return ret;
2786-
}
2780+
mce_threshold_create_device(cpu);
27872781
mce_reenable_cpu();
27882782
mce_start_timer(t);
27892783
return 0;

0 commit comments

Comments
 (0)