fix: reclaim jobs are created for pvs in deletion phase

The PersistentVolumeClaimReconciler invoked processReclaimSpace even
when PVCs were already in the deletion phase. This behavior triggered
the creation of reclaim jobs that prevented the underlying volume from
being deleted. Similarly, the ReclaimSpaceCronJobReconciler created
ReclaimSpaceJobs for ReclaimSpaceCronJobs in the deletion phase.  When
managed by a GitOps operator, this resulted in an infinite loop of job
creation and deletion.
The same behavior was also observed for EncryptionKeyRotationCronJobs.
This was also fixed as part of this commit.

Signed-off-by: Ivan Hell <ivan.hell@solunio.com>

Author: hellivan

internal/controller/csiaddons/encryptionkeyrotationcronjob_controller.go

@@ -64,6 +64,12 @@ func (r *EncryptionKeyRotationCronJobReconciler) Reconcile(ctx context.Context,
 		return ctrl.Result{}, err
 	}
 
+	// Check if resource is being deleted
+	if !krcJob.DeletionTimestamp.IsZero() {
+		logger.Info("EncryptionKeyRotationCronJob is being deleted, exiting reconcile", "namespace", krcJob.Namespace, "name", krcJob.Name)
+		return ctrl.Result{}, nil
+	}
+
 	// Set default values for the optionals
 	if krcJob.Spec.FailedJobsHistoryLimit == nil {
 		*krcJob.Spec.FailedJobsHistoryLimit = defaultFailedJobsHistoryLimit

internal/controller/csiaddons/persistentvolumeclaim_controller.go

@@ -118,6 +118,13 @@ func (r *PersistentVolumeClaimReconciler) Reconcile(ctx context.Context, req ctr
 		return ctrl.Result{}, err
 	}
 
+	// Check if the PVC is being deleted
+	if !pvc.DeletionTimestamp.IsZero() {
+		logger.Info("PVC is being deleted, exiting reconcile", "namespace", pvc.Namespace, "name", pvc.Name)
+		// requeue the request
+		return ctrl.Result{}, nil
+	}
+
 	// Validate PVC in bound state
 	if pvc.Status.Phase != corev1.ClaimBound {
 		logger.Info("PVC is not in bound state", "PVCPhase", pvc.Status.Phase)

internal/controller/csiaddons/reclaimspacecronjob_controller.go

@@ -80,6 +80,12 @@ func (r *ReclaimSpaceCronJobReconciler) Reconcile(ctx context.Context, req ctrl.
 		return ctrl.Result{}, err
 	}
 
+	// Check if resource is being deleted
+	if !rsCronJob.DeletionTimestamp.IsZero() {
+		logger.Info("ReclaimSpaceCronJob is being deleted, exiting reconcile", "namespace", rsCronJob.Namespace, "name", rsCronJob.Name)
+		return ctrl.Result{}, nil
+	}
+
 	// set history limit defaults, if not specified.
 	if rsCronJob.Spec.FailedJobsHistoryLimit == nil {
 		*rsCronJob.Spec.FailedJobsHistoryLimit = defaultFailedJobsHistoryLimit