Merge branch 'master' into GPT-root

Author: montyly

.github/workflows/deploy.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Build artifacts
         run: mdbook build
       - name: Upload artifact
-        uses: actions/upload-pages-artifact@v1
+        uses: actions/upload-pages-artifact@v2
         with:
           path: ./book
   deploy:
@@ -43,4 +43,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v1
+        uses: actions/deploy-pages@v2

.github/workflows/echidna.yml

@@ -115,20 +115,20 @@ jobs:
             config: Popsicle.yaml
             contract: PopsicleFixed
             outcome: success
-            expected: 'totalBalanceAfterTransferIsPreserved(address,uint256):\s*passed'
+            expected: 'totalBalanceAfterTransferIsPreserved(address,uint256):\s*passing'
           - name: TestDepositWithPermit
             workdir: program-analysis/echidna/example/
             files: TestDepositWithPermit.sol
             solc-version: 0.8.0
             config: testdeposit.yaml
             contract: TestDepositWithPermit
             outcome: success
-            expected: 'testERC20PermitDeposit(uint256):\s*passed'
+            expected: 'testERC20PermitDeposit(uint256):\s*passing'
           - name: MultiABI
             workdir: program-analysis/echidna/example/
-            files: multiabi.sol
+            files: allContracts.sol
             solc-version: 0.8.0
-            config: multiabi.yaml
+            config: allContracts.yaml
             contract: EchidnaTest
             outcome: failure
             expected: 'test_flag_is_false():\s*failed'
@@ -167,7 +167,7 @@ jobs:
           contract: ${{ matrix.contract }}
           config: ${{ matrix.config }}
           output-file: ${{ matrix.files }}.out
-          solc-version: ${{ matrix.solc-version || '0.5.11' }}
+          solc-version: ${{ matrix.solc-version || '0.8.0' }}
           echidna-workdir: ${{ matrix.workdir }}
           echidna-version: edge
           crytic-args: ${{ matrix.crytic-args || '' }}

.github/workflows/lint_links.yml

@@ -12,14 +12,15 @@ on:
       - ".github/workflows/lint_links.yml"
       - "**.md"
   schedule:
-    # run CI at 09:00, on day 1 of the month even if no PRs/merges occur
-    - cron: "0 9 1 * *"
+    # run CI at 09:00 every Tuesday even if no PRs/merges occur
+    - cron: "0 9 * * 2"
 
 jobs:
   markdown-link-check:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v3
       - uses: gaurav-nelson/github-action-markdown-link-check@v1
         with:
           use-quiet-mode: "yes"
+          check-modified-files-only: ${{ (github.event_name == 'pull_request' && 'yes') || 'no' }}

.gitignore

@@ -1 +1,2 @@
 .DS_Store
+node_modules

CONTRIBUTING.md

@@ -10,7 +10,7 @@ Please submit bug reports and feature suggestions to our issue tracker. When rep
 
 ## Questions
 
-You can submit questions to the issue tracker, but you might receive a quicker response if you ask in our [chat room](https://empireslacking.herokuapp.com/) (in the #ethereum channel).
+Questions can be submitted to the issue tracker, but you may get a faster response if you ask in our [chat room](https://slack.empirehacking.nyc/) (in the #ethereum channel).
 
 ## Code Contributions
 

README.md

@@ -14,6 +14,7 @@ Brought to you by [Trail of Bits](https://www.trailofbits.com/), this repository
 - [Learn EVM](./learn_evm): Technical knowledge about EVM
   - [EVM Opcodes](./learn_evm/evm_opcodes.md): Information on all EVM opcodes
   - [Transaction Tracing](./learn_evm/tracing.md): Helper scripts and guidance for generating and navigating transaction traces
+  - [Arithmetic Checks](./learn_evm/arithmetic-checks.md): A guide to performing arithmetic checks in the EVM
   - [Yellow Paper Guidance](./learn_evm/yellow-paper.md): Symbol reference for easier reading of the Ethereum yellow paper
   - [Forks <> EIPs](./learn_evm/eips_forks.md): Summaries of the EIPs included in each Ethereum fork
     - [Forks <> CIPs](./learn_evm/cips_forks.md): Summaries of the CIPs and EIPs included in each Celo fork _(EVM-compatible chain)_

SUMMARY.md

@@ -10,6 +10,7 @@
 - [Learn EVM](./learn_evm/README.md)
   - [EVM Opcode Reference](./learn_evm/evm_opcodes.md)
   - [Transaction Tracing](./learn_evm/tracing.md)
+  - [Arithmetic Checks](./learn_evm/arithmetic-checks.md)
   - [Yellow Paper Guidance](./learn_evm/yellow-paper.md):
     - [Forks and EIPs](./learn_evm/eips_forks.md)
     - [Forks and CIPs](./learn_evm/cips_forks.md)
@@ -26,6 +27,8 @@
     - [Access Controls](./not-so-smart-contracts/algorand/access_controls/README.md)
     - [Asset ID Check](./not-so-smart-contracts/algorand/asset_id_check/README.md)
     - [Denial of Service](./not-so-smart-contracts/algorand/denial_of_service/README.md)
+    - [Inner Transaction Fee](./not-so-smart-contracts/algorand/inner_transaction_fee/README.md)
+    - [Clear State Transaction Check](./not-so-smart-contracts/algorand/clear_state_transaction_check/README.md)
   - [Cairo](./not-so-smart-contracts/cairo/README.md)
     - [Improper Access Controls](./not-so-smart-contracts/cairo/access_controls/README.md)
     - [Integer Division Errors](./not-so-smart-contracts/cairo/integer_division/README.md)
@@ -66,21 +69,22 @@
       - [Introduction to Fuzzing](./program-analysis/echidna/introduction/fuzzing-introduction.md)
       - [How to Test a Property](./program-analysis/echidna/introduction/how-to-test-a-property.md)
     - [Basic](./program-analysis/echidna/basic/README.md)
-      - [Selecting the Most Suitable Testing Mode](./program-analysis/echidna/basic/testing-modes.md)
-      - [Selecting the Best Testing Approach](./program-analysis/echidna/basic/common-testing-approaches.md)
-      - [Filtering Functions](./program-analysis/echidna/basic/filtering-functions.md)
-      - [Testing Assertions](./program-analysis/echidna/basic/assertion-checking.md)
-      - [Writing Good Properties Step by Step](./program-analysis/echidna/basic/property-creation.md)
+      - [How to select the most suitable testing mode](./program-analysis/echidna/basic/testing-modes.md)
+      - [How to select the best testing approach](./program-analysis/echidna/basic/common-testing-approaches.md)
+      - [How to filter functions](./program-analysis/echidna/basic/filtering-functions.md)
+      - [How to test assertions](./program-analysis/echidna/basic/assertion-checking.md)
+      - [How to write good properties step by step](./program-analysis/echidna/basic/property-creation.md)
+      - [How to write properties that use ether](./program-analysis/echidna/basic/working-with-eth.md)
     - [Advanced](./program-analysis/echidna/advanced/README.md)
-      - [Collecting a Corpus](./program-analysis/echidna/advanced/collecting-a-corpus.md)
-      - [Using Optimization Mode](./program-analysis/echidna/advanced/optimization_mode.md)
-      - [Detecting High Gas Consumption](./program-analysis/echidna/advanced/finding-transactions-with-high-gas-consumption.md)
-      - [Smart Contract Fuzzing at Large Scale](./program-analysis/echidna/advanced/smart-contract-fuzzing-at-scale.md)
-      - [Testing Bytecode-Only Contracts](./program-analysis/echidna/advanced/testing-bytecode.md)
-      - [Using Hevm Cheats to Test Permit](./program-analysis/echidna/advanced/hevm-cheats-to-test-permit.md)
-      - [Seeding Echidna with Unit Tests](./program-analysis/echidna/advanced/end-to-end-testing.md)
-      - [Understanding and Using `multi-abi`](./program-analysis/echidna/advanced/using-multi-abi.md)
-    - [Fuzzing Tips](./program-analysis/echidna/fuzzing_tips.md)
+      - [How to collect a corpus](./program-analysis/echidna/advanced/collecting-a-corpus.md)
+      - [How to use optimization mode](./program-analysis/echidna/advanced/optimization_mode.md)
+      - [How to detect high gas consumption](./program-analysis/echidna/advanced/finding-transactions-with-high-gas-consumption.md)
+      - [How to perform smart contract fuzzing at a large scale](./program-analysis/echidna/advanced/smart-contract-fuzzing-at-scale.md)
+      - [How to test bytecode-only contracts](./program-analysis/echidna/advanced/testing-bytecode.md)
+      - [How to use hevm cheats to test permit](./program-analysis/echidna/advanced/hevm-cheats-to-test-permit.md)
+      - [How to seed Echidna with unit tests](./program-analysis/echidna/advanced/end-to-end-testing.md)
+      - [Understanding and using `multi-abi`](./program-analysis/echidna/advanced/using-multi-abi.md)
+    - [Fuzzing tips](./program-analysis/echidna/fuzzing_tips.md)
     - [Frequently Asked Questions](./program-analysis/echidna/frequently_asked_questions.md)
     - [Exercises](./program-analysis/echidna/exercises/README.md)
       - [Exercise 1](./program-analysis/echidna/exercises/Exercise-1.md)

book

@@ -15,6 +15,7 @@ no-section-label = true
 additional-css = ["static/custom.css"]
 additional-js = ["static/script.js"]
 default-theme = "light"
+mathjax-support = true
 
 [output.html.fold]
 enable = true

book.toml

@@ -1,6 +1,6 @@
-List of smart contract development best practices
+List of Best Practices for Smart Contract Development
 
-- [High-level best practices](./guidelines.md): High-level best-practices for all smart contracts
-- [Token integration checklist](./token_integration.md): What to check when interacting with arbitrary tokens
-- [Incident Response Recommendations](./incident_response.md): Guidelines on how to formulate an incident response plan
-- [Secure development workflow](./workflow.md): A rough, high-level process to follow while you write code
+- [High-Level Best Practices](./guidelines.md): Essential high-level best practices for all smart contracts
+- [Token Integration Checklist](./token_integration.md): Important aspects to consider when interacting with various tokens
+- [Incident Response Recommendations](./incident_response.md): Guidelines on establishing an effective incident response plan
+- [Secure Development Workflow](./workflow.md): A recommended high-level process to adhere to while writing code