Refactor resolvers slightly

Author: RX14

src/resolvers/git.cr

@@ -41,23 +41,12 @@ module Shards
       end
     end
 
-    def specs(versions)
-      specs = {} of String => Spec
-
-      versions.each do |version|
-        refs = git_refs(version)
-        yaml = capture("git show #{refs}:#{SPEC_FILENAME}")
-        specs[version] = Spec.from_yaml(yaml).tap { |spec| spec.resolver = self }
-      rescue Error
-      end
-
-      specs
+    def spec(version = nil)
+      Spec.from_yaml(read_spec(version)).tap { |spec| spec.resolver = self }
     end
 
-    def spec?(version)
-      refs = git_refs(version)
-      yaml = capture("git show #{refs}:#{SPEC_FILENAME}")
-      Spec.from_yaml(yaml)
+    private def spec?(version)
+      spec(version)
     rescue Error
     end
 

src/resolvers/path.cr

@@ -20,13 +20,10 @@ module Shards
       @dependency.path
     end
 
-    def spec?(version)
-      spec_path = File.join(local_path, SPEC_FILENAME)
-
-      if File.exists?(spec_path)
-        Spec.from_yaml(File.read(spec_path))
-        # TODO: fail if the spec isn't the expected version!
-      end
+    def spec(version = nil)
+      spec = Spec.from_yaml(read_spec(version))
+      spec.resolver = self
+      spec
     end
 
     def installed_spec

src/resolvers/resolver.cr

@@ -11,13 +11,12 @@ module Shards
     def initialize(@dependency)
     end
 
-    def spec(version = nil)
-      Spec.from_yaml(read_spec(version)).tap { |spec| spec.resolver = self }
-    end
-
     def specs(versions)
       specs = {} of String => Spec
-      versions.each { |version| specs[version] = spec(version) }
+      versions.each do |version|
+        specs[version] = spec(version)
+      rescue Error
+      end
       specs
     end
 
@@ -35,7 +34,7 @@ module Shards
     end
 
     abstract def read_spec(version = nil)
-    abstract def spec?(version)
+    abstract def spec(version)
     abstract def available_versions
     abstract def install(version = nil)
     abstract def installed_commit_hash