Merge pull request #323 from crystal-lang/ci/crystal-tool-format

Run crystal tool format --check in travis

Author: straight-shoota

.circleci/config.yml

@@ -14,6 +14,7 @@ dry:
     - run: shards install
     - run: make
     - run: make test
+    - run: crystal tool format --check
 
 jobs:
   test:

.travis.yml

@@ -12,3 +12,4 @@ before_script: |
 
 script:
   - make test
+  - crystal tool format --check

test/dependency_test.cr

@@ -16,14 +16,14 @@ class Shards::DependencyTest < Minitest::Test
   end
 
   def test_version_with_tags
-    dependency = Dependency.new("app", { tag: "fix/something" })
+    dependency = Dependency.new("app", {tag: "fix/something"})
     assert_equal "*", dependency.version
 
-    dependency = Dependency.new("app", { tag: "1.2.3" })
+    dependency = Dependency.new("app", {tag: "1.2.3"})
     assert_equal "*", dependency.version
 
     # version tag is considered a version:
-    dependency = Dependency.new("app", { tag: "v1.2.3-pre1" })
+    dependency = Dependency.new("app", {tag: "v1.2.3-pre1"})
     assert_equal "1.2.3-pre1", dependency.version
   end
 end

test/integration/install_test.cr

@@ -74,8 +74,8 @@ class InstallCommandTest < Minitest::Test
   def test_installs_prerelease_version_at_refs
     metadata = {
       dependencies: {
-        unstable: {git: git_url(:unstable), branch: "master"}
-      }
+        unstable: {git: git_url(:unstable), branch: "master"},
+      },
     }
     with_shard(metadata) do
       run "shards install"
@@ -130,7 +130,7 @@ class InstallCommandTest < Minitest::Test
   def test_installs_dependency_at_locked_commit_when_refs_is_a_branch
     metadata = {
       dependencies: {
-        web: {git: git_url(:web), branch: "master"}
+        web: {git: git_url(:web), branch: "master"},
       },
     }
     lock = {web: git_commits(:web)[-5]}
@@ -161,10 +161,10 @@ class InstallCommandTest < Minitest::Test
     metadata = {
       dependencies: {
         "locked": {git: git_path(:"locked"), branch: "master"},
-      }
+      },
     }
     lock = {
-      "locked": git_commits(:"locked").last
+      "locked": git_commits(:"locked").last,
     }
     with_shard(metadata, lock) { run "shards install" }
 
@@ -310,7 +310,7 @@ class InstallCommandTest < Minitest::Test
   end
 
   def test_runs_postinstall_with_transitive_dependencies
-    with_shard({ dependencies: {transitive: "*"} }) do
+    with_shard({dependencies: {transitive: "*"}}) do
       run "shards install"
       binary = File.join(application_path, "lib", "transitive", "version")
       assert File.exists?(binary)
@@ -332,7 +332,7 @@ class InstallCommandTest < Minitest::Test
 
   def test_installs_executables_at_version
     metadata = {
-      dependencies: {binary: "0.1.0"}
+      dependencies: {binary: "0.1.0"},
     }
     with_shard(metadata) { run("shards install --no-color") }
 
@@ -351,7 +351,7 @@ class InstallCommandTest < Minitest::Test
   def test_installs_executables_at_refs
     metadata = {
       dependencies: {
-        binary: {git: git_url(:binary), commit: git_commits(:binary)[-1]}
+        binary: {git: git_url(:binary), commit: git_commits(:binary)[-1]},
       },
     }
     with_shard(metadata) { run("shards install --no-color") }

test/integration/update_test.cr

@@ -55,7 +55,7 @@ class UpdateCommandTest < Minitest::Test
   end
 
   def test_updates_specified_dependencies
-    metadata = { dependencies: {web: "*", orm: "*", optional: "*"}, }
+    metadata = {dependencies: {web: "*", orm: "*", optional: "*"}}
     lock = {web: "1.0.0", orm: "0.4.0", optional: "0.2.0"}
 
     with_shard(metadata, lock) do
@@ -78,7 +78,7 @@ class UpdateCommandTest < Minitest::Test
   end
 
   def test_wont_install_prerelease_version
-    metadata = { dependencies: {unstable: "*"} }
+    metadata = {dependencies: {unstable: "*"}}
     lock = {unstable: "0.1.0"}
 
     with_shard(metadata, lock) do
@@ -89,7 +89,7 @@ class UpdateCommandTest < Minitest::Test
   end
 
   def test_installs_specified_prerelease_version
-    metadata = { dependencies: {unstable: "~> 0.3.0.alpha"} }
+    metadata = {dependencies: {unstable: "~> 0.3.0.alpha"}}
     lock = {unstable: "0.3.0.alpha"}
 
     with_shard(metadata, lock) do
@@ -100,7 +100,7 @@ class UpdateCommandTest < Minitest::Test
   end
 
   def test_updates_locked_specified_prerelease
-    metadata = { dependencies: {unstable: "~> 0.3.0.alpha"} }
+    metadata = {dependencies: {unstable: "~> 0.3.0.alpha"}}
     lock = {unstable: "0.3.0.alpha"}
 
     with_shard(metadata, lock) do
@@ -111,7 +111,7 @@ class UpdateCommandTest < Minitest::Test
   end
 
   def test_updates_from_prerelease_to_release_with_approximate_operator
-    metadata = { dependencies: {preview: "~> 0.3.0.a"} }
+    metadata = {dependencies: {preview: "~> 0.3.0.a"}}
     lock = {preview: "0.3.0.alpha"}
 
     with_shard(metadata, lock) do
@@ -123,7 +123,7 @@ class UpdateCommandTest < Minitest::Test
 
   # TODO: detect version, and prefer release (0.3.0) over further prereleases (?)
   def test_updates_to_latest_prerelease_with_gte_operator
-    metadata = { dependencies: {preview: ">= 0.3.0.a"} }
+    metadata = {dependencies: {preview: ">= 0.3.0.a"}}
     lock = {preview: "0.3.0.a"}
 
     with_shard(metadata, lock) do
@@ -208,7 +208,7 @@ class UpdateCommandTest < Minitest::Test
   end
 
   def test_runs_postinstall_with_transitive_dependencies
-    with_shard({ dependencies: {transitive: "*"} }, {transitive: "0.1.0"}) do
+    with_shard({dependencies: {transitive: "*"}}, {transitive: "0.1.0"}) do
       run "shards update"
       binary = File.join(application_path, "lib", "transitive", "version")
       assert File.exists?(binary)
@@ -236,7 +236,7 @@ class UpdateCommandTest < Minitest::Test
 
   def test_doesnt_update_local_cache
     metadata = {
-      dependencies: { local_cache: "*" },
+      dependencies: {local_cache: "*"},
     }
 
     with_shard(metadata) do

test/integration_helper.cr

@@ -53,8 +53,8 @@ class Minitest::Test
     create_path_repository "foo", "0.1.0"
 
     # dependency with neither a shard.yml and/or version tags:
-    #create_git_repository "empty"
-    #create_git_commit "empty", "initial release"
+    # create_git_repository "empty"
+    # create_git_commit "empty", "initial release"
 
     create_git_repository "missing"
     create_shard "missing", "name: missing\nversion: 0.1.0\n"

test/support/cli.cr

@@ -39,10 +39,10 @@ module Shards
                 when String
                   yml << "    git: " << git_url(name).inspect << '\n'
                   yml << "    version: " << version.inspect << '\n'
-                #when Hash
-                #  version.each do |k, v|
-                #    yml << "    " << k << ": " << v.inspect << '\n'
-                #  end
+                  # when Hash
+                  #  version.each do |k, v|
+                  #    yml << "    " << k << ": " << v.inspect << '\n'
+                  #  end
                 when NamedTuple
                   version.each do |k, v|
                     yml << "    " << k.to_s << ": " << v.inspect << '\n'