Drop support for CrateDB < 2.0.0

Author: amotl

CHANGES.txt

@@ -8,7 +8,7 @@ Unreleased
 - Added official support for Python 3.9 and 3.10.
 - Dropped support for SQLAlchemy 1.1 and 1.2.
 
-- Dropped support for CrateDB < 1.0.0.
+- Dropped support for CrateDB < 2.0.0.
 
 
 - BREAKING CHANGE: The driver now verifies SSL certificates when connecting via

src/crate/client/doctests/connection.txt

@@ -10,7 +10,7 @@ We create a new connection object::
 
     >>> connection = connect(client=connection_client_mocked)
     >>> connection.lowest_server_version.version
-    (1, 42, 0)
+    (2, 0, 0)
 
 Calling the ``cursor()`` function on the connection will
 return a cursor object::

src/crate/client/sqlalchemy/dialect.py

@@ -35,8 +35,6 @@
 from crate.client.exceptions import TimezoneUnawareException
 from .types import Object, ObjectArray
 
-TABLE_TYPE_MIN_VERSION = (2, 0, 0)
-
 TYPES_MAP = {
     "boolean": sqltypes.Boolean,
     "short": sqltypes.SmallInteger,
@@ -230,13 +228,11 @@ def get_schema_names(self, connection, **kw):
 
     @reflection.cache
     def get_table_names(self, connection, schema=None, **kw):
-        table_filter = "AND table_type = 'BASE TABLE' " \
-            if self.server_version_info >= TABLE_TYPE_MIN_VERSION else ""
         cursor = connection.execute(
             "SELECT table_name FROM information_schema.tables "
-            "WHERE {0} = ? {1}"
-            "ORDER BY table_name ASC, {0} ASC".format(self.schema_column,
-                                                      table_filter),
+            "WHERE {0} = ? "
+            "AND table_type = 'BASE TABLE' "
+            "ORDER BY table_name ASC, {0} ASC".format(self.schema_column),
             [schema or self.default_schema_name]
         )
         return [row[0] for row in cursor.fetchall()]

src/crate/client/sqlalchemy/tests/dialect_test.py

@@ -94,10 +94,4 @@ def test_get_table_names(self):
         self.engine.dialect.server_version_info = (2, 0, 0)
         eq_(insp.get_table_names(self.connection, "doc"),
             ['t1', 't2'])
-        in_("AND table_type = 'BASE TABLE' ORDER BY", self.executed_statement)
-
-        insp = inspect(self.character.metadata.bind)
-        self.engine.dialect.server_version_info = (1, 0, 0)
-        eq_(insp.get_table_names(self.connection, "doc"),
-            ['t1', 't2'])
-        in_("WHERE table_schema = ? ORDER BY", self.executed_statement)
+        in_("WHERE table_schema = ? AND table_type = 'BASE TABLE' ORDER BY", self.executed_statement)

src/crate/client/tests.py

@@ -75,7 +75,7 @@ class ClientMocked(object):
 
     def __init__(self):
         self.response = {}
-        self._server_infos = ("http://localhost:4200", "my server", "1.42.0")
+        self._server_infos = ("http://localhost:4200", "my server", "2.0.0")
 
     def sql(self, stmt=None, parameters=None, bulk_parameters=None):
         return self.response