Skip to content

Fixed printing case with Safari #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixed printing case with Safari #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
acdc792
Fixed safari blank page
ps-horkimsereirith Mar 29, 2023
d71884f
Revert "Fixed safari blank page"
ps-horkimsereirith Mar 29, 2023
c242cec
Fixed printing on safari show blank page
ps-horkimsereirith Mar 29, 2023
b25ccc6
Rename package and readme
ps-horkimsereirith Mar 29, 2023
9404ed6
Update release version
ps-horkimsereirith Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@ You can download the latest version of Print.js from the [GitHub releases](https
To install via npm:

```bash
npm install print-js --save
npm install custom-print-js --save
```

To install via yarn:

```bash
yarn add print-js
yarn add custom-print-js
```

Import the library into your project:

```js
import printJS from 'print-js'
import printJS from 'custom-print-js'
```

## Documentation
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "print-js",
"name": "custom-print-js",
"homepage": "http://printjs.crabbly.com",
"description": "A tiny javascript library to help printing from the web.",
"version": "1.6.0",
"version": "1.6.1",
"main": "dist/print.js",
"types": "src/index.d.ts",
"repository": "https://github.com/crabbly/Print.js",
Expand Down
4 changes: 2 additions & 2 deletions src/js/print.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const Print = {
iframeElement.onload = () => {
if (params.type === 'pdf') {
// Add a delay for Firefox. In my tests, 1000ms was sufficient but 100ms was not
if (Browser.isFirefox() && Browser.getFirefoxMajorVersion() < 110) {
if ((Browser.isFirefox() && Browser.getFirefoxMajorVersion() < 110) || Browser.isSafari()) {
setTimeout(() => performPrint(iframeElement, params), 1000)
} else {
performPrint(iframeElement, params)
Expand Down Expand Up @@ -72,7 +72,7 @@ function performPrint (iframeElement, params) {
} catch (error) {
params.onError(error)
} finally {
if (Browser.isFirefox() && Browser.getFirefoxMajorVersion() < 110) {
if ((Browser.isFirefox() && Browser.getFirefoxMajorVersion() < 110) || Browser.isSafari()) {
// Move the iframe element off-screen and make it invisible
iframeElement.style.visibility = 'hidden'
iframeElement.style.left = '-1px'
Expand Down