ScopedTempDirectory stores error type

#improvement

Author: alandefreitas

src/lib/Support/Path.cpp

@@ -487,7 +487,7 @@ ScopedTempFile(
 
 ScopedTempDirectory::
 ~ScopedTempDirectory() {
-    if (ok_)
+    if (*this)
     {
         llvm::sys::fs::remove_directories(path_);
     }
@@ -498,11 +498,12 @@ ScopedTempDirectory(
     llvm::StringRef prefix)
 {
     llvm::SmallString<128> tempPath;
-    ok_ = !llvm::sys::fs::createUniqueDirectory(prefix, tempPath);
-    if (ok_)
+    if (llvm::sys::fs::createUniqueDirectory(prefix, tempPath))
     {
-        path_ = tempPath;
+        status_ = ErrorStatus::CannotCreateDirectories;
+        return;
     }
+    path_ = tempPath;
 }
 
 ScopedTempDirectory::
@@ -513,19 +514,33 @@ ScopedTempDirectory(
     llvm::SmallString<128> tempPath(root);
     llvm::sys::path::append(tempPath, dir);
     bool const exists = llvm::sys::fs::exists(tempPath);
-    if (exists)
+    if (exists &&
+        llvm::sys::fs::remove_directories(tempPath))
     {
-        ok_ = !llvm::sys::fs::remove_directories(tempPath);
-        if (!ok_)
-        {
-            return;
-        }
+        status_ = ErrorStatus::CannotDeleteExisting;
+        return;
     }
-    ok_ = !llvm::sys::fs::create_directory(tempPath);
-    if (ok_)
+    if (llvm::sys::fs::create_directories(tempPath))
     {
-        path_ = tempPath;
+        status_ = ErrorStatus::CannotCreateDirectories;
+        return;
+    }
+    path_ = tempPath;
+}
+
+Error
+ScopedTempDirectory::
+error() const
+{
+    if (status_ == ErrorStatus::CannotDeleteExisting)
+    {
+        return Error("Failed to delete existing directory");
+    }
+    if (status_ == ErrorStatus::CannotCreateDirectories)
+    {
+        return Error("Failed to create directories");
     }
+    return Error();
 }
 
 } // mrdocs

src/lib/Support/Path.hpp

@@ -85,8 +85,16 @@ class ScopedTempFile
 */
 class ScopedTempDirectory
 {
+    // Status of the directory
+    enum class ErrorStatus
+    {
+        None,
+        CannotDeleteExisting,
+        CannotCreateDirectories
+    };
+
     clang::mrdocs::SmallPathString path_;
-    bool ok_ = false;
+    ErrorStatus status_ = ErrorStatus::None;
 public:
     /** Destructor
 
@@ -129,12 +137,27 @@ class ScopedTempDirectory
 
     /** Returns `true` if the directory was created successfully.
     */
-    operator bool() const { return ok_; }
+    operator bool() const
+    {
+        return status_ == ErrorStatus::None;
+    }
+
+    /** Returns `true` if the directory was not created successfully.
+    */
+    bool
+    failed() const
+    {
+        return status_ != ErrorStatus::None;
+    }
 
     /** Returns the path to the temporary directory.
      */
     std::string_view path() const { return static_cast<llvm::StringRef>(path_); }
 
+    /** Returns the error status of the directory.
+     */
+    Error error() const;
+
     /** Convert temp directory to a std::string_view
      */
     operator std::string_view() const { return path(); }

src/tool/GenerateAction.cpp

@@ -138,6 +138,11 @@ DoGenerateAction(
         compilationDatabasePath,
         "The compilation database path argument is missing");
     ScopedTempDirectory tempDir(config->settings().output, ".temp");
+    if (tempDir.failed())
+    {
+        report::error("Failed to create temporary directory: {}", tempDir.error());
+        return Unexpected(tempDir.error());
+    }
     std::string buildPath = files::appendPath(tempDir, "build");
     Expected<std::string> const compileCommandsPathExp =
         generateCompileCommandsFile(