rename HasOverrideAttr to IsOverride

Author: sdkrystian

docs/modules/ROOT/pages/generators.adoc

@@ -330,9 +330,9 @@ When the symbol kind is `function`, the symbol object has the following addition
 | `bool`
 | Whether the function is noreturn.
 
-| `hasOverrideAttr`
+| `isOverride`
 | `bool`
-| Whether the function has the override attribute.
+| Whether the function is override.
 
 | `hasTrailingReturn`
 | `bool`

include/mrdocs/Metadata/Info/Function.hpp

@@ -166,7 +166,7 @@ struct FunctionInfo final
     bool IsDeleted = false;
     bool IsDeletedAsWritten = false;
     bool IsNoReturn = false;
-    bool HasOverrideAttr = false;
+    bool IsOverride = false;
     bool HasTrailingReturn = false;
     bool IsNodiscard = false;
     bool IsExplicitObjectMemberFunction = false;
@@ -221,7 +221,7 @@ tag_invoke(
     io.map("isDeleted", I.IsDeleted);
     io.map("isDeletedAsWritten", I.IsDeletedAsWritten);
     io.map("isNoReturn", I.IsNoReturn);
-    io.map("hasOverrideAttr", I.HasOverrideAttr);
+    io.map("isOverride", I.IsOverride);
     io.map("hasTrailingReturn", I.HasTrailingReturn);
     io.map("isConst", I.IsConst);
     io.map("isVolatile", I.IsVolatile);

share/mrdocs/addons/generator/common/partials/symbol/signature/function.hbs

@@ -28,7 +28,7 @@
 {{#if requires}}
 
 requires {{requires}}{{/if~}}
-{{#if hasOverrideAttr}} override{{/if~}}
+{{#if isOverride}} override{{/if~}}
 {{#if isFinal}} final{{/if~}}
 {{#if isPure}} = 0{{/if~}}
 {{#if isDeleted}} = delete{{/if~}}

src/lib/AST/ASTVisitor.cpp

@@ -801,7 +801,6 @@ populate(
     I.IsDeleted |= D->isDeleted();
     I.IsDeletedAsWritten |= D->isDeletedAsWritten();
     I.IsNoReturn |= D->isNoReturn();
-    I.HasOverrideAttr |= D->hasAttr<OverrideAttr>();
 
     if (ConstexprSpecKind const CSK = D->getConstexprKind();
         CSK != ConstexprSpecKind::Unspecified)
@@ -927,6 +926,7 @@ populate(FunctionInfo& I, CXXMethodDecl const* D)
     I.IsVolatile |= D->isVolatile();
     I.RefQualifier = toReferenceKind(D->getRefQualifier());
     I.IsFinal |= D->hasAttr<FinalAttr>();
+    I.IsOverride |= D->hasAttr<OverrideAttr>();
 }
 
 void

src/lib/Gen/xml/XMLWriter.cpp

@@ -334,7 +334,7 @@ writeFunction(
     writeAttr(I.IsDeleted,             "is-deleted", tags_);
     writeAttr(I.IsDeletedAsWritten,    "is-deleted-as-written", tags_);
     writeAttr(I.IsNoReturn,            "is-no-return", tags_);
-    writeAttr(I.HasOverrideAttr,       "has-override", tags_);
+    writeAttr(I.IsOverride,            "is-override", tags_);
     writeAttr(I.HasTrailingReturn,     "has-trailing-return", tags_);
     writeAttr(I.Constexpr,             "constexpr-kind", tags_);
     writeAttr(I.OverloadedOperator,    "operator", tags_);

src/lib/Metadata/Info/Function.cpp

@@ -331,11 +331,11 @@ merge(FunctionInfo& I, FunctionInfo&& Other)
     I.IsDeleted |= Other.IsDeleted;
     I.IsDeletedAsWritten |= Other.IsDeletedAsWritten;
     I.IsNoReturn |= Other.IsNoReturn;
-    I.HasOverrideAttr |= Other.HasOverrideAttr;
     I.HasTrailingReturn |= Other.HasTrailingReturn;
     I.IsConst |= Other.IsConst;
     I.IsVolatile |= Other.IsVolatile;
     I.IsFinal |= Other.IsFinal;
+    I.IsOverride |= Other.IsOverride;
     I.IsNodiscard |= Other.IsNodiscard;
     I.IsExplicitObjectMemberFunction |= Other.IsExplicitObjectMemberFunction;
     if (I.Constexpr == ConstexprKind::None)

test-files/golden-tests/filters/symbol-name/excluded-base-class.xml

@@ -13,11 +13,11 @@
       </function>
       <function name="g" id="o+85JO3Sv4bIWiG3+bfyUw5gJWI=">
         <file short-path="excluded-base-class.cpp" source-path="excluded-base-class.cpp" line="17"/>
-        <attr id="has-override"/>
+        <attr id="is-override"/>
       </function>
       <function name="h" id="NiHV825xQJhfQDhKCeAex3UuHGY=">
         <file short-path="excluded-base-class.cpp" source-path="excluded-base-class.cpp" line="18"/>
-        <attr id="has-override"/>
+        <attr id="is-override"/>
       </function>
       <function name="i" id="d5/JtPJCrP6OG8ToxUKNR5xqJ4I=">
         <file short-path="excluded-base-class.cpp" source-path="excluded-base-class.cpp" line="19"/>
@@ -37,7 +37,7 @@
       </function>
       <function name="h" id="KiY+7o+uUp3h7bndNOpI2AuCrAE=">
         <file short-path="excluded-base-class.cpp" source-path="excluded-base-class.cpp" line="29"/>
-        <attr id="has-override"/>
+        <attr id="is-override"/>
       </function>
       <function name="i" id="0wO8aZwuOLvF7/RooHUZJ5SyKzk=">
         <file short-path="excluded-base-class.cpp" source-path="excluded-base-class.cpp" line="30"/>

test-files/golden-tests/symbols/function/mem-fn.xml

@@ -115,7 +115,7 @@
     </base>
     <function name="f" id="5+yfyWtDpz80IwKT3xugro18Ev0=">
       <file short-path="mem-fn.cpp" source-path="mem-fn.cpp" line="20"/>
-      <attr id="has-override"/>
+      <attr id="is-override"/>
     </function>
   </struct>
   <struct name="U" id="FLgkhM3m0U3Lo2o3XLPUizWPH00=">
@@ -163,7 +163,7 @@
     </function>
     <function name="f3" exception-spec="noexcept" id="/C2pxLlwRMKnr6YRbVnykUArzEI=">
       <file short-path="mem-fn.cpp" source-path="mem-fn.cpp" line="31"/>
-      <attr id="has-override"/>
+      <attr id="is-override"/>
       <attr id="is-const"/>
       <attr id="is-volatile"/>
       <return>