base class references evaluate extraction mode

#feat

Author: alandefreitas

docs/mrdocs.schema.json

@@ -160,12 +160,12 @@
     },
     "inherit-base-members": {
       "default": "copy-dependencies",
-      "description": "Determine how derived classes inherit members of base classes. When set to `never`, derived classes do not inherit members of base classes and only the relationship is stored. When set to `reference`, derived classes list members of base classes but references are still linked to the base class. When set to `copy`, a copy is created for each base symbol as if it was declared in the derived class. If the base class is a dependency, the extraction mode is copied from the new parent. When set to `copy-dependencies`, a reference is created by default and a copy is created when the base class is a dependency.",
+      "description": "Determine how derived classes inherit members of base classes. When set to `never`, derived classes do not inherit members of base classes and only the relationship is stored. When set to `reference`, derived classes list members of base classes but references are still linked to the base class. When set to `copy-dependencies`, a reference is created by default and a copy is created when the base class is a dependency. When set to `copy-all`, a copy is created for each base symbol as if it was declared in the derived class. If the base class is a dependency, the extraction mode is copied from the new parent.",
       "enum": [
         "never",
         "reference",
-        "copy",
-        "copy-dependencies"
+        "copy-dependencies",
+        "copy-all"
       ],
       "title": "Determine how derived classes inherit base members"
     },

src/lib/Lib/ConfigOptions.json

@@ -181,13 +181,13 @@
       {
         "name": "inherit-base-members",
         "brief": "Determine how derived classes inherit base members",
-        "details": "Determine how derived classes inherit members of base classes. When set to `never`, derived classes do not inherit members of base classes and only the relationship is stored. When set to `reference`, derived classes list members of base classes but references are still linked to the base class. When set to `copy`, a copy is created for each base symbol as if it was declared in the derived class. If the base class is a dependency, the extraction mode is copied from the new parent. When set to `copy-dependencies`, a reference is created by default and a copy is created when the base class is a dependency.",
+        "details": "Determine how derived classes inherit members of base classes. When set to `never`, derived classes do not inherit members of base classes and only the relationship is stored. When set to `reference`, derived classes list members of base classes but references are still linked to the base class. When set to `copy-dependencies`, a reference is created by default and a copy is created when the base class is a dependency. When set to `copy-all`, a copy is created for each base symbol as if it was declared in the derived class. If the base class is a dependency, the extraction mode is copied from the new parent.",
         "type": "enum",
         "values": [
           "never",
           "reference",
-          "copy",
-          "copy-dependencies"
+          "copy-dependencies",
+          "copy-all"
         ],
         "default": "copy-dependencies"
       },

src/lib/Metadata/Finalizers/BaseMembersFinalizer.cpp

@@ -78,6 +78,19 @@ inheritBaseMembers(
     inheritBaseMembers(derivedId, derived.Friends, base.Friends);
 }
 
+namespace {
+bool
+shouldCopy(Config const& config, Info const& M)
+{
+
+    if (config->inheritBaseMembers == PublicSettings::BaseMemberInheritance::CopyDependencies)
+    {
+        return M.Extraction == ExtractionMode::Dependency;
+    }
+    return config->inheritBaseMembers == PublicSettings::BaseMemberInheritance::CopyAll;
+}
+}
+
 void
 BaseMembersFinalizer::
 inheritBaseMembers(
@@ -122,15 +135,19 @@ inheritBaseMembers(
             });
         MRDOCS_CHECK_OR_CONTINUE(shadowIt == derived.end());
 
-        bool const copyMember =
-            config_->inheritBaseMembers == PublicSettings::BaseMemberInheritance::CopyDependencies ?
-                otherInfo.Extraction == ExtractionMode::Dependency :
-                config_->inheritBaseMembers == PublicSettings::BaseMemberInheritance::Copy;
-
         // Not a shadow, so inherit the base member
-        if (!copyMember)
+        if (!shouldCopy(config_, otherInfo))
         {
-            derived.push_back(otherID);
+            // When it's a dependency, we don't create a reference to
+            // the member because the reference would be invalid.
+            // The user can use `copy-dependencies` or `copy` to
+            // copy the dependencies.
+            // There could be another option that forces the symbol
+            // extraction mode to be regular, but that is controversial.
+            if (otherInfo.Extraction != ExtractionMode::Dependency)
+            {
+                derived.push_back(otherID);
+            }
         }
         else
         {

util/generate-config-info.py

@@ -65,7 +65,7 @@ def get_valid_enum_categories():
     valid_enum_cats = {
         'generator': ["adoc", "html", "xml"],
         'log-level': ["trace", "debug", "info", "warn", "error", "fatal"],
-        'base-member-inheritance': ["never", "reference", "copy", "copy-dependencies"]
+        'base-member-inheritance': ["never", "reference", "copy-dependencies", "copy-all"]
     }
     return valid_enum_cats