isDefinition and isDocumented are clang helpers

#refactor

Author: alandefreitas

src/lib/AST/ASTVisitor.cpp

@@ -509,23 +509,6 @@ generateID(Decl const* D) const
     return id;
 }
 
-namespace
-{
-template <class DeclTy>
-bool
-isDefinition(DeclTy* D)
-{
-    if constexpr (requires {D->isThisDeclarationADefinition();})
-    {
-        return D->isThisDeclarationADefinition();
-    }
-    else
-    {
-        return false;
-    }
-}
-}
-
 template <std::derived_from<Decl> DeclTy>
 void
 ASTVisitor::
@@ -560,7 +543,7 @@ populate(SourceInfo& I, DeclTy const* D)
             dynamic_cast<SourceInfo&>(I),
             Loc,
             isDefinition(D),
-            D->getASTContext().getRawCommentForDeclNoCache(D));
+            isDocumented(D));
     }
 }
 
@@ -3366,7 +3349,7 @@ checkUndocumented(
     // Check if the symbol is documented, ensure this symbol is not in the set
     // of undocumented symbols in this translation unit and return
     // without an error if it is
-    if (D->getASTContext().getRawCommentForDeclNoCache(D))
+    if (isDocumented(D))
     {
         if (config_->warnIfUndocumented)
         {

src/lib/AST/ClangHelpers.cpp

@@ -355,7 +355,7 @@ isVirtualMember(Decl const* D)
 }
 
 bool
-isAnonymousNamespace(const Decl *D)
+isAnonymousNamespace(Decl const* D)
 {
     if (auto const* ND = dyn_cast<NamespaceDecl>(D))
     {
@@ -365,7 +365,7 @@ isAnonymousNamespace(const Decl *D)
 }
 
 bool
-isStaticFileLevelMember(const Decl *D)
+isStaticFileLevelMember(Decl const* D)
 {
     if (const auto *VD = dyn_cast<VarDecl>(D)) {
         return VD->getStorageClass() == SC_Static && VD->getDeclContext()->isFileContext();
@@ -376,5 +376,11 @@ isStaticFileLevelMember(const Decl *D)
     return false;
 }
 
+bool
+isDocumented(Decl const* D)
+{
+    return D->getASTContext().getRawCommentForDeclNoCache(D);
+}
+
 
 } // clang::mrdocs

src/lib/AST/ClangHelpers.hpp

@@ -844,6 +844,24 @@ MRDOCS_DECL
 bool
 isStaticFileLevelMember(Decl const *D);
 
+MRDOCS_DECL
+bool
+isDocumented(Decl const *D);
+
+template <class DeclTy>
+bool
+isDefinition(DeclTy* D)
+{
+    if constexpr (requires {D->isThisDeclarationADefinition();})
+    {
+        return D->isThisDeclarationADefinition();
+    }
+    else
+    {
+        return false;
+    }
+}
+
 #ifdef NDEBUG
 #define MRDOCS_SYMBOL_TRACE(D, C)
 #else