Skip to content

Commit 0e76e48

Browse files
NerixyzNerixyz
committed
fix: compilation with BUILD_SHARED_LIBS with MSVC
1 parent 03d1a75 commit 0e76e48

File tree

19 files changed

+104
-30
lines changed

19 files changed

+104
-30
lines changed

‎.github/workflows/ci.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
apple-clang *
4141
standards: '20'
4242
latest-factors: |
43-
msvc Optimized-Debug
43+
msvc Optimized-Debug Shared
4444
gcc Coverage
4545
factors: ''
4646
runs-on: |
@@ -375,6 +375,7 @@ jobs:
375375
package-dir: packages
376376
package-generators: ${{ matrix.mrdocs-package-generators }}
377377
package-artifact: false
378+
shared: ${{ matrix.shared }}
378379

379380
- name: Check YAML schema
380381
run: |

‎CMakeLists.txt‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -292,10 +292,10 @@ if (WIN32)
292292
target_compile_options(
293293
mrdocs-core
294294
PUBLIC
295-
/permissive- # strict C++
296-
/W4 # enable all warnings
297-
/MP # multi-processor compilation
298-
/EHs # C++ Exception handling
295+
/permissive- # strict C++
296+
/W4 # enable all warnings
297+
$<$<CXX_COMPILER_ID:MSVC>:/MP> # multi-processor compilation
298+
/EHs # C++ Exception handling
299299
)
300300
endif()
301301
endif ()
@@ -325,7 +325,6 @@ list(APPEND TOOL_SOURCES
325325
${CMAKE_CURRENT_BINARY_DIR}/src/tool/PublicToolArgs.cpp)
326326

327327
add_executable(mrdocs ${TOOL_SOURCES})
328-
target_compile_definitions(mrdocs PRIVATE -DMRDOCS_TOOL)
329328

330329
target_include_directories(mrdocs
331330
PUBLIC
@@ -337,7 +336,6 @@ target_include_directories(mrdocs
337336
"${PROJECT_BINARY_DIR}/src"
338337
)
339338

340-
target_compile_definitions(mrdocs PRIVATE -DMRDOCS_TOOL)
341339
target_link_libraries(mrdocs PUBLIC mrdocs-core)
342340
if (MRDOCS_CLANG)
343341
target_compile_options(

‎include/mrdocs/Config.hpp‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class MRDOCS_DECL
6060
public:
6161
/** Settings values used to generate the Corpus and Docs
6262
*/
63-
struct Settings : public PublicSettings
63+
struct MRDOCS_DECL Settings : public PublicSettings
6464
{
6565
/**
6666
* @brief Loads the public configuration settings from the specified YAML file.
@@ -156,13 +156,11 @@ class MRDOCS_DECL
156156

157157
/** Destructor.
158158
*/
159-
MRDOCS_DECL
160159
virtual
161160
~Config() noexcept = 0;
162161

163162
/** Return a pool of threads for executing work.
164163
*/
165-
MRDOCS_DECL
166164
virtual
167165
ThreadPool&
168166
threadPool() const noexcept = 0;

‎include/mrdocs/Dom/Array.hpp‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ class MRDOCS_DECL
281281
/** Return a diagnostic string.
282282
*/
283283
friend
284+
MRDOCS_DECL
284285
std::string
285286
toString(Array const&);
286287

@@ -364,6 +365,13 @@ class MRDOCS_DECL
364365
DefaultArrayImpl();
365366
explicit DefaultArrayImpl(
366367
storage_type elements) noexcept;
368+
369+
DefaultArrayImpl(const DefaultArrayImpl&);
370+
DefaultArrayImpl(DefaultArrayImpl&&);
371+
DefaultArrayImpl& operator=(const DefaultArrayImpl&);
372+
DefaultArrayImpl& operator=(DefaultArrayImpl&&);
373+
~DefaultArrayImpl();
374+
367375
size_type size() const override;
368376
value_type get(size_type i) const override;
369377
void set(size_type i, Value v) override;

‎include/mrdocs/Dom/Object.hpp‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ class MRDOCS_DECL
318318

319319
/** Return a diagnostic string.
320320
*/
321-
friend std::string toString(Object const&);
321+
friend MRDOCS_DECL std::string toString(Object const&);
322322
};
323323

324324
//------------------------------------------------
@@ -402,6 +402,11 @@ class MRDOCS_DECL
402402
{
403403
public:
404404
DefaultObjectImpl() noexcept;
405+
DefaultObjectImpl(const DefaultObjectImpl&);
406+
DefaultObjectImpl(DefaultObjectImpl&&);
407+
DefaultObjectImpl& operator=(const DefaultObjectImpl&);
408+
DefaultObjectImpl& operator=(DefaultObjectImpl&&);
409+
~DefaultObjectImpl();
405410

406411
explicit DefaultObjectImpl(
407412
storage_type entries) noexcept;

‎include/mrdocs/Dom/Value.hpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,11 @@ namespace mrdocs {
4646
4747
@see https://handlebarsjs.com/api-reference/utilities.html#handlebars-safestring-string
4848
*/
49+
MRDOCS_DECL
4950
dom::Value
5051
safeString(std::string_view str);
5152

53+
MRDOCS_DECL
5254
dom::Value
5355
safeString(dom::Value const& str);
5456

@@ -523,6 +525,7 @@ class MRDOCS_DECL
523525
/** Return value as a string.
524526
*/
525527
friend
528+
MRDOCS_DECL
526529
std::string
527530
toString(Value const& value);
528531
};

‎include/mrdocs/Metadata/Javadoc.hpp‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,6 +371,12 @@ struct Copied : Reference
371371
struct MRDOCS_DECL
372372
Block : Node
373373
{
374+
Block(const Block&) = delete;
375+
Block(Block&&);
376+
Block& operator=(const Block&) = delete;
377+
Block& operator=(Block&&);
378+
~Block();
379+
374380
List<Text> children;
375381

376382
bool isBlock() const noexcept final
@@ -919,7 +925,6 @@ class MRDOCS_DECL
919925
public:
920926
/** Constructor.
921927
*/
922-
MRDOCS_DECL
923928
Javadoc() noexcept;
924929

925930
/** Constructor
@@ -928,6 +933,11 @@ class MRDOCS_DECL
928933
Javadoc(
929934
doc::List<doc::Block> blocks);
930935

936+
Javadoc(const Javadoc&) = delete;
937+
Javadoc(Javadoc&&);
938+
Javadoc& operator=(const Javadoc&) = delete;
939+
Javadoc& operator=(Javadoc&&);
940+
931941
/** Return true if this is empty
932942
*/
933943
bool

‎include/mrdocs/Platform.hpp‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#ifndef MRDOCS_API_PLATFORM_HPP
1212
#define MRDOCS_API_PLATFORM_HPP
1313

14-
#include <mrdocs/Support/Assert.hpp>
1514
#include <type_traits>
1615

1716
#if __cplusplus < 202002L
@@ -79,4 +78,6 @@ namespace mrdocs {
7978
} // mrdocs
8079
} // clang
8180

81+
#include <mrdocs/Support/Assert.hpp>
82+
8283
#endif

‎include/mrdocs/Support/Assert.hpp‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#ifndef MRDOCS_API_SUPPORT_ASSERT_HPP
1212
#define MRDOCS_API_SUPPORT_ASSERT_HPP
1313

14+
#include <mrdocs/Platform.hpp>
1415
#include <cstdint>
1516

1617
namespace clang {
@@ -30,6 +31,7 @@ namespace mrdocs {
3031
#define MRDOCS_UNREACHABLE() static_cast<void>(__debugbreak(), __assume(false))
3132
#endif
3233

34+
MRDOCS_DECL
3335
void
3436
assert_failed(
3537
const char* msg,

‎include/mrdocs/Support/JavaScript.hpp‎

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ class MRDOCS_DECL Value
414414
via @ref Scope::reset.
415415
416416
*/
417-
MRDOCS_DECL ~Value();
417+
~Value();
418418

419419
/** Constructor
420420
@@ -424,36 +424,36 @@ class MRDOCS_DECL Value
424424
The value is undefined.
425425
426426
*/
427-
MRDOCS_DECL Value() noexcept;
427+
Value() noexcept;
428428

429429
/** Constructor
430430
431431
The function pushes a duplicate of
432432
value to the stack and associates
433433
the new value the top of the stack.
434434
*/
435-
MRDOCS_DECL Value(Value const&);
435+
Value(Value const&);
436436

437437
/** Constructor
438438
439439
The function associates the
440440
existing value with this object.
441441
*/
442-
MRDOCS_DECL Value(Value&&) noexcept;
442+
Value(Value&&) noexcept;
443443

444444
/** Copy assignment.
445445
446446
@copydetails Value(Value const&)
447447
448448
*/
449-
MRDOCS_DECL Value& operator=(Value const&);
449+
Value& operator=(Value const&);
450450

451451
/** Move assignment.
452452
453453
@copydetails Value(Value&&)
454454
455455
*/
456-
MRDOCS_DECL Value& operator=(Value&&) noexcept;
456+
Value& operator=(Value&&) noexcept;
457457

458458
/** Return the type of the value.
459459
@@ -476,7 +476,7 @@ class MRDOCS_DECL Value
476476
internal ECMAScript class `Function`.
477477
478478
*/
479-
MRDOCS_DECL Type type() const noexcept;
479+
Type type() const noexcept;
480480

481481
/// Check if the value is undefined.
482482
bool
@@ -706,15 +706,13 @@ class MRDOCS_DECL Value
706706

707707
/** Set or replace the value for a given key.
708708
*/
709-
MRDOCS_DECL
710709
void
711710
set(
712711
std::string_view key,
713712
Value const& value) const;
714713

715714
/** Set or replace the value for a given key.
716715
*/
717-
MRDOCS_DECL
718716
void
719717
set(
720718
std::string_view key,
@@ -932,16 +930,13 @@ class MRDOCS_DECL Value
932930
toString(Value const& value);
933931

934932
private:
935-
MRDOCS_DECL
936933
Expected<Value>
937934
callImpl(
938935
std::initializer_list<dom::Value> args) const;
939936

940-
MRDOCS_DECL
941937
Expected<Value>
942938
callImpl(std::span<dom::Value> args) const;
943939

944-
MRDOCS_DECL
945940
Expected<Value>
946941
callPropImpl(
947942
std::string_view prop,

0 commit comments

Comments
 (0)