refactor clang-format

Author: shenxianpeng

cpp_linter_hooks/clang_format.py

@@ -1,4 +1,5 @@
 import subprocess
+import sys
 from argparse import ArgumentParser
 from typing import Tuple
 
@@ -16,35 +17,58 @@ def run_clang_format(args=None) -> Tuple[int, str]:
     hook_args, other_args = parser.parse_known_args(args)
     path = ensure_installed("clang-format", hook_args.version)
     command = [str(path), "-i"]
+
+    # Add verbose flag if requested
+    if hook_args.verbose:
+        command.append("--verbose")
+
     command.extend(other_args)
 
-    retval = 0
-    output = ""
     try:
+        # Run the clang-format command with captured output
+        sp = subprocess.run(
+            command,
+            stdout=subprocess.PIPE,
+            stderr=subprocess.PIPE,
+            encoding="utf-8",
+        )
+
+        # Combine stdout and stderr for complete output
+        output = (sp.stdout or "") + (sp.stderr or "")
+
+        # Handle special case for dry-run mode
         if "--dry-run" in command:
-            sp = subprocess.run(
-                command,
-                stdout=subprocess.PIPE,
-                stderr=subprocess.PIPE,
-                encoding="utf-8",
-            )
-            retval = -1  # Not a fail just identify it's a dry-run.
-            output = sp.stdout + sp.stderr
+            retval = -1  # Special code to identify dry-run mode
         else:
-            retval = subprocess.run(
-                command, stdout=subprocess.PIPE, stderr=subprocess.PIPE
-            ).returncode
+            retval = sp.returncode
+
+        # Print verbose information if requested
+        if hook_args.verbose:
+            _print_verbose_info(command, retval, output)
+
         return retval, output
-    except FileNotFoundError as stderr:
-        retval = 1
-        return retval, str(stderr)
+
+    except FileNotFoundError as e:
+        return 1, str(e)
+
+
+def _print_verbose_info(command: list, retval: int, output: str) -> None:
+    """Print verbose debugging information to stderr."""
+    print(f"Command executed: {' '.join(command)}", file=sys.stderr)
+    print(f"Exit code: {retval}", file=sys.stderr)
+    if output.strip():
+        print(f"Output: {output}", file=sys.stderr)
 
 
 def main() -> int:
     retval, output = run_clang_format()
-    if retval != 0:
+
+    # Print output for errors, but not for dry-run mode
+    if retval != 0 and retval != -1 and output.strip():
         print(output)
-    return retval
+
+    # Convert dry-run special code to success
+    return 0 if retval == -1 else retval
 
 
 if __name__ == "__main__":