Install on macosx working

Author: amrox

bin/download

@@ -4,20 +4,14 @@ set -euo pipefail
 
 current_script_path=${BASH_SOURCE[0]}
 plugin_dir=$(dirname "$(dirname "$current_script_path")")
+sub_toolname=$(basename "$plugin_dir")
 
 # shellcheck source=../lib/utils.bash
 source "${plugin_dir}/lib/utils.bash"
 
 mkdir -p "$ASDF_DOWNLOAD_PATH"
 
-# TODO: Adapt this to proper extension and adapt extracting strategy.
-release_file="$ASDF_DOWNLOAD_PATH/$TOOL_NAME-$ASDF_INSTALL_VERSION.tar.gz"
+# TODO:: remove this?
+release_file="${ASDF_DOWNLOAD_PATH}/${sub_toolname}-${ASDF_INSTALL_VERSION}"
 
-# Download tar.gz file to the download directory
-download_release "$ASDF_INSTALL_VERSION" "$release_file"
-
-#  Extract contents of tar.gz file into the download directory
-tar -xzf "$release_file" -C "$ASDF_DOWNLOAD_PATH" --strip-components=1 || fail "Could not extract $release_file"
-
-# Remove the tar.gz file since we don't need to keep it
-rm "$release_file"
+download_release "$sub_toolname" "$ASDF_INSTALL_VERSION" "$release_file"

bin/install

@@ -4,9 +4,9 @@ set -euo pipefail
 
 current_script_path=${BASH_SOURCE[0]}
 plugin_dir=$(dirname "$(dirname "$current_script_path")")
-toolname=$(basename "$plugin_dir")
+sub_toolname=$(basename "$plugin_dir")
 
 # shellcheck source=../lib/utils.bash
 source "${plugin_dir}/lib/utils.bash"
 
-install_version "${toolname}" "$ASDF_INSTALL_TYPE" "$ASDF_INSTALL_VERSION" "$ASDF_INSTALL_PATH"
+install_version "$sub_toolname" "$ASDF_INSTALL_TYPE" "$ASDF_INSTALL_VERSION" "$ASDF_INSTALL_PATH"

lib/utils.bash

@@ -10,6 +10,7 @@ TOOL_TEST="clang-format"
 USE_KERNEL=
 USE_ARCH=
 USE_PLATFORM=
+YES_REGEX='^[Yy](E|e)?(S|s)?$'
 
 fail() {
   echo -e "asdf-$TOOL_NAME: $*"
@@ -27,6 +28,10 @@ validate_deps() {
   done
 }
 
+log() {
+  echo -e "asdf-$TOOL_NAME: $*"
+}
+
 curl_opts=(-fsSL)
 
 # NOTE: You might want to remove this if clang-tools-static is not hosted on GitHub releases.
@@ -53,7 +58,7 @@ fetch_all_assets() {
 
 validate_platform() {
 
-  if [ -n "${USE_PLATFORM}" ]; then
+  if [ -n "$USE_PLATFORM" ]; then
     return
   fi
 
@@ -98,38 +103,87 @@ list_all_versions() {
 }
 
 download_release() {
-  local version filename url
-  version="$1"
-  filename="$2"
+  local toolname version filename url
+  toolname="$1"
+  version="$2"
+  filename="$3"
+
+  validate_platform
+
+  # TODO: split output without piping to awk
+  url=$(fetch_all_assets |
+    grep "^${toolname}-${version}_${USE_PLATFORM}\s" |
+    awk '{print $2}')
+
+  (
+    cd "${ASDF_DOWNLOAD_PATH}" || exit 1
 
-  # TODO: Adapt the release URL convention for clang-tools-static
-  url="$GH_REPO_URL/archive/v${version}.tar.gz"
+    echo "* Downloading $toolname release $version..."
+    #curl "${curl_opts[@]}" -o "$filename" "$url" || fail "Could not download $url"
+    curl "${curl_opts[@]}" -O "$url" || fail "Could not download $url"
+    # TODO: range request ('-C -') does not seem to work
 
-  echo "* Downloading $TOOL_NAME release $version..."
-  curl "${curl_opts[@]}" -o "$filename" -C - "$url" || fail "Could not download $url"
+    # Download checksum
+    #curl "${curl_opts[@]}" -o "${filename}.sha512sum" "${url}.sha512sum" || fail "Could not download $url"
+    curl "${curl_opts[@]}" -O "${url}.sha512sum" || fail "Could not download $url"
+  )
 }
 
 install_version() {
-  local install_type="$1"
-  local version="$2"
-  local install_path="$3"
+  local toolname="$1"
+  local install_type="$2"
+  local version="$3"
+  local install_path="$4"
+
+  validate_platform
 
   if [ "$install_type" != "version" ]; then
     fail "asdf-$TOOL_NAME supports release installs only"
   fi
 
+  if command -v sha512sum >/dev/null; then
+    (
+      log "Checking sha512 sum..."
+      cd "${ASDF_DOWNLOAD_PATH}" || exit 1
+      sha512sum -c ./*.sha512sum
+    )
+  else
+    log "WARNING: sha512sum program not found - unable to checksum. Proceed with caution."
+  fi
+
   (
-    mkdir -p "$install_path"
-    cp -r "$ASDF_DOWNLOAD_PATH"/* "$install_path"
+    local asset_path full_tool_cmd tool_cmd
+    asset_path="$install_path/assets"
+
+    mkdir -p "$asset_path"
+    cp -r "$ASDF_DOWNLOAD_PATH"/* "$asset_path"
+
+    # TODO: detect this instead of hard-coding in case the format changes?
+    full_tool_cmd=${toolname}-${version}_${USE_PLATFORM}
+    tool_cmd="$(echo "$toolname" | cut -d' ' -f1)"
+
+    chmod +x "${asset_path}/${full_tool_cmd}"
+
+    mkdir -p "${install_path}/bin" || true
+    ln -s "${asset_path}/${full_tool_cmd}" "$install_path/bin/$tool_cmd"
+
+    if [ "$USE_KERNEL" == "macosx" ]; then
+      log "$toolname needs to be un-quarantined to run:\n\n"
+      echo -e "  xattr -dr com.apple.quarantine \"${asset_path}/${full_tool_cmd}\""
+      echo -e -n "\n\nProceed? [y/N] "
+      read -r reply
+      if [[ $reply =~ $YES_REGEX ]]; then
+        xattr -dr com.apple.quarantine "${asset_path}/${full_tool_cmd}"
+      else
+        exit 1
+      fi
+    fi
 
-    # TODO: Asert clang-tools-static executable exists.
-    local tool_cmd
-    tool_cmd="$(echo "$TOOL_TEST" | cut -d' ' -f1)"
     test -x "$install_path/bin/$tool_cmd" || fail "Expected $install_path/bin/$tool_cmd to be executable."
 
-    echo "$TOOL_NAME $version installation was successful!"
+    echo "$toolname $version installation was successful!"
   ) || (
     rm -rf "$install_path"
-    fail "An error ocurred while installing $TOOL_NAME $version."
+    fail "An error ocurred while installing $toolname $version."
   )
 }