Remove goutils logger #7886
Merged
Remove goutils logger #7886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the direct dependency on github.com/couchbase/goutils by eliminating the CBGoUtilsLogger implementation, converting it from a direct to an indirect dependency (still used by cbgt for cbauth). The change simplifies Sync Gateway's logging infrastructure by removing an unused external logger adapter.
Key Changes
- Removed direct dependency on
goutilsfromgo.mod(moved to indirect dependencies) - Eliminated the CBGoUtilsLogger implementation and its initialization from
base/logger_external.go - Removed unused imports (
fmt,os, andgoutils/logging) from the logger file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Moved goutils from direct to indirect dependency |
| base/logger_external.go | Removed CBGoUtilsLogger implementation and cleaned up unused imports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove goutils logger
This is just a proposal. I can see the benefit of leaving this in if cbgt decides to use this for something else. However, they have their own logging utility so this seems unlikely.
I believe this was used only from go-couchbase. This drops a direct dependency to an indirect dependency from cbgt only. It is used by cbgt to access cbauth which Sync Gateway is never going to use. https://github.com/couchbase/cbgt/blob/74dbd1c34db313c2b65a65f6e3cecca7eacb00b3/cbauth.go#L24 / https://github.com/couchbase/cbauth
Inspired from #7881