fix: Use default value for num_tokens in ingester configuration (#544)

CharlieTLe · web-flow · commit 0f642a371045 · 2025-06-17T08:49:30.000+02:00
* fix: reduce num_tokens from 512 to 128 for ingester configuration Fixes: #543 Signed-off-by: Charlie Le <charlie_le@apple.com> * chore: update CHANGELOG to set default ingester.num-tokens to 128 Signed-off-by: Charlie Le <charlie_le@apple.com> * default to no override for num_tokens Signed-off-by: Charlie Le <charlie_le@apple.com> --------- Signed-off-by: Charlie Le <charlie_le@apple.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## master / unreleased
 
+* [CHANGE] Use default value for num_tokens in ingester configuration #544
+
 ## 2.6.0 / 2025-05-07
 
 * [DEPENDENCY] Update Helm release memcached to v6.14.0 #528
diff --git a/README.md b/README.md
@@ -230,7 +230,6 @@ Kubernetes: `^1.19.0-0`
 | config.&ZeroWidthSpace;frontend.&ZeroWidthSpace;log_queries_longer_than | string | `"10s"` |  |
 | config.&ZeroWidthSpace;ingester.&ZeroWidthSpace;lifecycler.&ZeroWidthSpace;final_sleep | string | `"30s"` | Duration to sleep for before exiting, to ensure metrics are scraped. |
 | config.&ZeroWidthSpace;ingester.&ZeroWidthSpace;lifecycler.&ZeroWidthSpace;join_after | string | `"10s"` | We don't want to join immediately, but wait a bit to see other ingesters and their tokens first. It can take a while to have the full picture when using gossip |
-| config.&ZeroWidthSpace;ingester.&ZeroWidthSpace;lifecycler.&ZeroWidthSpace;num_tokens | int | `512` |  |
 | config.&ZeroWidthSpace;ingester.&ZeroWidthSpace;lifecycler.&ZeroWidthSpace;observe_period | string | `"10s"` | To avoid generating same tokens by multiple ingesters, they can "observe" the ring for a while, after putting their own tokens into it. This is only useful when using gossip, since multiple ingesters joining at the same time can have conflicting tokens if they don't see each other yet. |
 | config.&ZeroWidthSpace;ingester.&ZeroWidthSpace;lifecycler.&ZeroWidthSpace;ring.&ZeroWidthSpace;kvstore.&ZeroWidthSpace;store | string | `"memberlist"` |  |
 | config.&ZeroWidthSpace;ingester.&ZeroWidthSpace;lifecycler.&ZeroWidthSpace;ring.&ZeroWidthSpace;replication_factor | int | `3` | Ingester replication factor per default is 3 |
diff --git a/values.yaml b/values.yaml
@@ -54,7 +54,6 @@ config:
       observe_period: 10s
       # -- Duration to sleep for before exiting, to ensure metrics are scraped.
       final_sleep: 30s
-      num_tokens: 512
       ring:
         # -- Ingester replication factor per default is 3
         replication_factor: 3
