Use wrapper for provider agnostic function

Author: RobertLucian

pkg/operator/config/wrappers.go

@@ -92,6 +92,16 @@ func BucketPath(key string) string {
 	return ""
 }
 
+func ReadBytesFromBucket(key string) ([]byte, error) {
+	switch Provider {
+	case types.AWSProviderType:
+		return AWS.ReadBytesFromS3(Cluster.Bucket, key)
+	case types.GCPProviderType:
+		return GCP.ReadBytesFromGCS(GCPCluster.Bucket, key)
+	}
+	return nil, nil
+}
+
 func ReadJSONFromBucket(objPtr interface{}, key string) error {
 	switch Provider {
 	case types.AWSProviderType:

pkg/operator/resources/resources.go

@@ -235,16 +235,7 @@ func patchAPI(apiConfig *userconfig.API, configFileName string, force bool) (*sp
 	}
 
 	if deployedResource.Kind != userconfig.TrafficSplitterKind {
-		var bytes []byte
-		var err error
-		if config.Provider == types.AWSProviderType {
-			bytes, err = config.AWS.ReadBytesFromS3(config.Cluster.Bucket, prevAPISpec.ProjectKey)
-		} else if config.Provider == types.GCPProviderType {
-			bytes, err = config.GCP.ReadBytesFromGCS(config.GCPCluster.Bucket, prevAPISpec.ProjectKey)
-		} else {
-			return nil, "", errors.ErrorUnexpected(fmt.Sprintf("unexpected provider type %s", config.Provider))
-		}
-
+		bytes, err := config.ReadBytesFromBucket(prevAPISpec.ProjectKey)
 		if err != nil {
 			return nil, "", err
 		}