You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: dev/versions.md
+15-11Lines changed: 15 additions & 11 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -86,23 +86,23 @@ Note: check their [install.md](https://github.com/kubernetes/client-go/blob/mast
86
86
1.`go mod tidy`
87
87
1. Check that the diff in `go.mod` is reasonable
88
88
89
-
## TensorFlow / TensorFlow Serving / Python / Python base operating system
89
+
## Python
90
90
91
-
The Python version in the base images for `tf-api` and `onnx-serve-gpu`/`python-serve-gpu` determines the Python version used throughout Cortex.
91
+
The same Python version should be used throughout Cortex (e.g. search for `3.6` and update all accordingly).
92
92
93
-
1. Update the `tensorflow/tensorflow` base image in `images/tf-api/Dockerfile` to the desired version ([Dockerhub](https://hub.docker.com/r/tensorflow/tensorflow))
94
-
1. Update the `nvidia/cuda` base image in `images/python-serve-gpu/Dockerfile` and `images/onnx-serve-gpu/Dockerfile` (as well as `libnvinfer` in `images/python-serve-gpu/Dockerfile` and `images/tf-serve-gpu/Dockerfile`) to the desired version based on [TensorFlow's documentation](https://www.tensorflow.org/install/gpu#ubuntu_1804_cuda_101) ([Dockerhub](https://hub.docker.com/r/nvidia/cuda)) (it's possible these versions will diverge depending on ONNX runtime support)
95
-
1. Run `docker run --rm -it tensorflow/tensorflow:***`, and in the container run `python3 --version` and `cat /etc/lsb-release`
96
-
1. Run `docker run --rm -it nvidia/cuda:***`, and in the container run `cat /etc/lsb-release`
97
-
1. The Ubuntu versions should match; if they do not, downgrade whichever one is too advanced
98
-
1. The minor Python version in `tensorflow/tensorflow` must be used in all dockerfiles; search for e.g. `python3.6-dev` and update accordingly
99
-
1. Update TensorFlow version listed in `tensorflow.md` and `python.md`
93
+
It's probably safest to use the minor version of Python that you get when you run `apt-get install python3` ([currently that's what TensorFlow's Docker image does](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/dockerfiles/dockerfiles/cpu.Dockerfile))
94
+
95
+
## TensorFlow / TensorFlow Serving
96
+
97
+
1. Find the latest release on [GitHub](https://github.com/tensorflow/tensorflow/releases)
100
98
1. Search the codebase for the current minor TensorFlow version (e.g. `2.1`) and update versions as appropriate
101
-
1. Search the codebase for the minor Python version (e.g. `3.6`) and update versions as appropriate
102
-
1. Search the codebase for `ubuntu` and update versions as appropriate
103
99
104
100
Note: it's ok if example training notebooks aren't upgraded, as long as the exported model still works
105
101
102
+
## CUDA
103
+
104
+
1. Update the `nvidia/cuda` base image in `images/python-serve-gpu/Dockerfile` and `images/onnx-serve-gpu/Dockerfile` (as well as `libnvinfer` in `images/python-serve-gpu/Dockerfile` and `images/tf-serve-gpu/Dockerfile`) to the desired version based on [TensorFlow's documentation](https://www.tensorflow.org/install/gpu#ubuntu_1804_cuda_101) ([Dockerhub](https://hub.docker.com/r/nvidia/cuda)) (it's possible these versions will diverge depending on ONNX runtime support)
105
+
106
106
## ONNX runtime
107
107
108
108
1. Update the version in `onnx-cpu.requirements.txt` and `onnx-gpu.requirements.txt` ([releases](https://github.com/microsoft/onnxruntime/releases))
@@ -204,6 +204,10 @@ Note: overriding horizontal-pod-autoscaler-sync-period on EKS is currently not s
204
204
1. Find the latest 2.X release on [GitHub](https://github.com/helm/helm/releases) (Istio does not work with helm 3)
205
205
1. Update the version in `images/manager/Dockerfile`
206
206
207
+
## Ubuntu base images
208
+
209
+
1. Search the codebase for `ubuntu` and update versions as appropriate
210
+
207
211
## Alpine base images
208
212
209
213
1. Find the latest release on [Dockerhub](https://hub.docker.com/_/alpine)
0 commit comments