Display single environment error message when there are no apis (#1076)

Author: vishalbollu

cli/cmd/get.go

@@ -146,21 +146,19 @@ func getAPIsInAllEnvironments() (string, error) {
 		return "", err
 	}
 
-	var errorEnvNames []string
 	var allAPIs []spec.API
 	var allAPIStatuses []status.Status
 	var allMetrics []metrics.Metrics
 	var allEnvs []string
-	allErrs := make([]error, len(cliConfig.Environments))
-	for i, env := range cliConfig.Environments {
+	errorsMap := map[string]error{}
+	for _, env := range cliConfig.Environments {
 		var apisRes schema.GetAPIsResponse
 		var err error
 		if env.Provider == types.AWSProviderType {
 			apisRes, err = cluster.GetAPIs(MustGetOperatorConfig(env.Name))
 		} else {
 			apisRes, err = local.GetAPIs()
 		}
-		allErrs[i] = err
 
 		if err == nil {
 			for range apisRes.APIs {
@@ -171,19 +169,19 @@ func getAPIsInAllEnvironments() (string, error) {
 			allAPIStatuses = append(allAPIStatuses, apisRes.Statuses...)
 			allMetrics = append(allMetrics, apisRes.AllMetrics...)
 		} else {
-			errorEnvNames = append(errorEnvNames, env.Name)
+			errorsMap[env.Name] = err
 		}
 	}
 
 	out := ""
 
 	if len(allAPIs) == 0 {
-		if len(cliConfig.Environments) == 1 && allErrs[0] != nil {
-			// Print the error if there is just one env
-			exit.Error(allErrs[0])
+		if len(errorsMap) == 1 {
+			// Print the error if there is just one
+			exit.Error(errors.FirstErrorInMap(errorsMap))
 		}
-		// if all envs errored, "no apis are deployed" is misleading, so skip it
-		if !errors.AreAllErrors(allErrs) {
+		// if all envs errored, skip it "no apis are deployed" since it's misleading
+		if len(errorsMap) != len(cliConfig.Environments) {
 			out += console.Bold("no apis are deployed") + "\n"
 		}
 	} else {
@@ -196,12 +194,12 @@ func getAPIsInAllEnvironments() (string, error) {
 		out += t.MustFormat()
 	}
 
-	if len(errorEnvNames) == 1 {
+	if len(errorsMap) == 1 {
 		out = s.EnsureBlankLineIfNotEmpty(out)
-		out += fmt.Sprintf("unable to detect apis from the %s environment; run `cortex get --env %s` if this is unexpected\n", errorEnvNames[0], errorEnvNames[0])
-	} else if len(errorEnvNames) > 1 {
+		out += fmt.Sprintf("unable to detect apis from the %s environment; run `cortex get --env %s` if this is unexpected\n", errors.FirstKeyInErrorMap(errorsMap), errors.FirstKeyInErrorMap(errorsMap))
+	} else if len(errorsMap) > 1 {
 		out = s.EnsureBlankLineIfNotEmpty(out)
-		out += fmt.Sprintf("unable to detect apis from the %s environments; run `cortex get --env ENV_NAME` if this is unexpected\n", s.StrsAnd(errorEnvNames))
+		out += fmt.Sprintf("unable to detect apis from the %s environments; run `cortex get --env ENV_NAME` if this is unexpected\n", s.StrsAnd(errors.NonNilErrorMapKeys(errorsMap)))
 	}
 
 	mismatchedAPIMessage, err := getLocalVersionMismatchedAPIsMessage()

pkg/lib/errors/multi.go

@@ -73,3 +73,40 @@ func FirstError(errs ...error) error {
 	}
 	return nil
 }
+
+func MapHasError(errs map[string]error) bool {
+	for _, err := range errs {
+		if err != nil {
+			return true
+		}
+	}
+	return false
+}
+
+func FirstErrorInMap(errs map[string]error) error {
+	for _, err := range errs {
+		if err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
+func FirstKeyInErrorMap(errs map[string]error) string {
+	for k, err := range errs {
+		if err != nil {
+			return k
+		}
+	}
+	return ""
+}
+
+func NonNilErrorMapKeys(errs map[string]error) []string {
+	var keys []string
+	for k, err := range errs {
+		if err != nil {
+			keys = append(keys, k)
+		}
+	}
+	return keys
+}