Skip to content

Commit e485409

Browse files
committed
Update variable name in ValidateClusterAPIs()
1 parent 57a689a commit e485409

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

pkg/operator/resources/validations.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ func ValidateClusterAPIs(apis []userconfig.API) error {
4444
if err != nil {
4545
return err
4646
}
47-
httpDeployedRealtimeAPIs := strset.New()
47+
deployedRealtimeAPIs := strset.New()
4848
for _, virtualService := range virtualServices {
4949
if virtualService.Labels["apiKind"] == userconfig.RealtimeAPIKind.String() {
50-
httpDeployedRealtimeAPIs.Add(virtualService.Labels["apiName"])
50+
deployedRealtimeAPIs.Add(virtualService.Labels["apiName"])
5151
}
5252
}
5353

@@ -71,7 +71,7 @@ func ValidateClusterAPIs(apis []userconfig.API) error {
7171
if err := spec.ValidateTrafficSplitter(api); err != nil {
7272
return errors.Wrap(err, api.Identify())
7373
}
74-
if err := checkIfAPIExists(api.APIs, realtimeAPIs, httpDeployedRealtimeAPIs); err != nil {
74+
if err := checkIfAPIExists(api.APIs, realtimeAPIs, deployedRealtimeAPIs); err != nil {
7575
return errors.Wrap(err, api.Identify())
7676
}
7777
if err := validateEndpointCollisions(api, virtualServices); err != nil {
@@ -264,12 +264,12 @@ func ExclusiveFilterAPIsByKind(apis []userconfig.API, kindsToExclude ...userconf
264264
}
265265

266266
// checkIfAPIExists checks if referenced apis in trafficsplitter are either defined in yaml or already deployed.
267-
func checkIfAPIExists(trafficSplitterAPIs []*userconfig.TrafficSplit, apis []userconfig.API, httpDeployedRealtimeAPIs strset.Set) error {
267+
func checkIfAPIExists(trafficSplitterAPIs []*userconfig.TrafficSplit, apis []userconfig.API, deployedRealtimeAPIs strset.Set) error {
268268
var missingAPIs []string
269269
// check if apis named in trafficsplitter are either defined in same yaml or already deployed
270270
for _, trafficSplitAPI := range trafficSplitterAPIs {
271271
// check if already deployed
272-
deployed := httpDeployedRealtimeAPIs.Has(trafficSplitAPI.Name)
272+
deployed := deployedRealtimeAPIs.Has(trafficSplitAPI.Name)
273273

274274
// check defined apis
275275
for _, definedAPI := range apis {

0 commit comments

Comments
 (0)