Skip to content

Commit df1af13

Browse files
authored
Prevent endpoint updates from triggering rolling replica updates (#1155)
1 parent 4771cbb commit df1af13

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

pkg/types/spec/api.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ type LocalModelCache struct {
5050
func GetAPISpec(apiConfig *userconfig.API, projectID string, deploymentID string) *API {
5151
var buf bytes.Buffer
5252
buf.WriteString(apiConfig.Name)
53-
if apiConfig.Networking.Endpoint != nil {
54-
buf.WriteString(*apiConfig.Networking.Endpoint)
55-
}
5653
if apiConfig.Networking.LocalPort != nil {
5754
buf.WriteString(s.Obj(*apiConfig.Networking.LocalPort))
5855
}

pkg/types/userconfig/api.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ func IdentifyAPI(filePath string, name string, index int) string {
174174
// InitReplicas was left out deliberately
175175
func (api *API) ToK8sAnnotations() map[string]string {
176176
return map[string]string{
177+
EndpointAnnotationKey: *api.Networking.Endpoint,
177178
APIGatewayAnnotationKey: api.Networking.APIGateway.String(),
178179
MinReplicasAnnotationKey: s.Int32(api.Autoscaling.MinReplicas),
179180
MaxReplicasAnnotationKey: s.Int32(api.Autoscaling.MaxReplicas),

pkg/types/userconfig/config_key.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ const (
7777
MaxUnavailableKey = "max_unavailable"
7878

7979
// K8s annotation
80+
EndpointAnnotationKey = "networking.cortex.dev/endpoint"
8081
APIGatewayAnnotationKey = "networking.cortex.dev/api-gateway"
8182
MinReplicasAnnotationKey = "autoscaling.cortex.dev/min-replicas"
8283
MaxReplicasAnnotationKey = "autoscaling.cortex.dev/max-replicas"

0 commit comments

Comments
 (0)