Skip to content

Commit de47939

Browse files
author
Miguel Varela Ramos
authored
Disable dynamic batcher for non python predictor types (#1888)
1 parent cf4b41e commit de47939

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

pkg/cortex/serve/cortex_internal/lib/api/api.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,11 @@ def __init__(
5353
self.statsd = datadog.statsd
5454

5555
@property
56-
def server_side_batching_enabled(self):
57-
return self.api_spec["predictor"].get("server_side_batching") is not None
56+
def python_server_side_batching_enabled(self):
57+
return (
58+
self.api_spec["predictor"].get("server_side_batching") is not None
59+
and self.api_spec["predictor"]["type"] == "python"
60+
)
5861

5962
def metric_dimensions_with_id(self):
6063
return [

pkg/cortex/serve/cortex_internal/serve/serve.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@
1515
import asyncio
1616
import inspect
1717
import json
18-
import math
1918
import os
20-
import sys
2119
import re
22-
import threading
20+
import sys
2321
import time
2422
import uuid
2523
from concurrent.futures import ThreadPoolExecutor
@@ -300,7 +298,7 @@ def start_fn():
300298
local_cache["predictor_impl"] = predictor_impl
301299
local_cache["predict_fn_args"] = inspect.getfullargspec(predictor_impl.predict).args
302300

303-
if api.server_side_batching_enabled:
301+
if api.python_server_side_batching_enabled:
304302
dynamic_batching_config = api.api_spec["predictor"]["server_side_batching"]
305303
local_cache["dynamic_batcher"] = DynamicBatcher(
306304
predictor_impl,

0 commit comments

Comments
 (0)