Remove virtualservice retries for realtime and traffic splitter APIs (#2419)

Author: deliahu

pkg/lib/k8s/virtual_service.go

@@ -45,6 +45,7 @@ type VirtualServiceSpec struct {
 	Labels       map[string]string
 	Annotations  map[string]string
 	Headers      *istionetworking.Headers
+	Retries      *int32
 }
 
 type Destination struct {
@@ -153,6 +154,14 @@ func VirtualService(spec *VirtualServiceSpec) *istioclientnetworking.VirtualServ
 		httpRoutes = append(httpRoutes, exactMatch, prefixMatch)
 	}
 
+	if spec.Retries != nil {
+		for i := range httpRoutes {
+			httpRoutes[i].Retries = &istionetworking.HTTPRetry{
+				Attempts: *spec.Retries,
+			}
+		}
+	}
+
 	virtualService := &istioclientnetworking.VirtualService{
 		TypeMeta: _virtualServiceTypeMeta,
 		ObjectMeta: kmeta.ObjectMeta{

pkg/operator/resources/realtimeapi/k8s_specs.go

@@ -149,6 +149,7 @@ func virtualServiceSpec(api *spec.API) *istioclientnetworking.VirtualService {
 		},
 		PrefixPath:  api.Networking.Endpoint,
 		Rewrite:     pointer.String("/"),
+		Retries:     pointer.Int32(0),
 		Annotations: api.ToK8sAnnotations(),
 		Labels: map[string]string{
 			"apiName":               api.Name,

pkg/operator/resources/trafficsplitter/k8s_specs.go

@@ -32,6 +32,7 @@ func virtualServiceSpec(trafficSplitter *spec.API) *istioclientnetworking.Virtua
 		Destinations: getTrafficSplitterDestinations(trafficSplitter),
 		ExactPath:    trafficSplitter.Networking.Endpoint,
 		Rewrite:      pointer.String("/"),
+		Retries:      pointer.Int32(0),
 		Annotations:  trafficSplitter.ToK8sAnnotations(),
 		Labels: map[string]string{
 			"apiName":               trafficSplitter.Name,