Initialize logger before accessing it in python code (#1810)

Author: vishalbollu

pkg/cortex/serve/cortex_internal/lib/api/api.py

@@ -23,7 +23,9 @@
 from cortex_internal.lib.api import Predictor
 from cortex_internal.lib.exceptions import CortexException
 from cortex_internal.lib.storage import S3, GCS
-from cortex_internal.lib.log import logger
+from cortex_internal.lib.log import configure_logger
+
+logger = configure_logger("cortex", os.environ["CORTEX_LOG_CONFIG_FILE"])
 
 
 class API:

pkg/cortex/serve/cortex_internal/lib/api/predictor.py

@@ -58,9 +58,11 @@
 # misc
 from cortex_internal.lib.storage import S3, GCS
 from cortex_internal.lib import util
-from cortex_internal.lib.log import logger
 from cortex_internal.lib.exceptions import CortexException, UserException, UserRuntimeException
 from cortex_internal import consts
+from cortex_internal.lib.log import configure_logger
+
+logger = configure_logger("cortex", os.environ["CORTEX_LOG_CONFIG_FILE"])
 
 
 class Predictor:

pkg/cortex/serve/cortex_internal/lib/api/task.py

@@ -17,8 +17,10 @@
 import inspect
 import dill
 
-from cortex_internal.lib.log import logger
 from cortex_internal.lib.exceptions import CortexException, UserException, UserRuntimeException
+from cortex_internal.lib.log import configure_logger
+
+logger = configure_logger("cortex", os.environ["CORTEX_LOG_CONFIG_FILE"])
 
 
 class TaskAPI:

pkg/cortex/serve/cortex_internal/lib/client/onnx.py

@@ -26,7 +26,6 @@
     onnx_dependencies_installed = False
 import numpy as np
 
-from cortex_internal.lib.log import logger
 from cortex_internal.lib import util
 from cortex_internal.lib.exceptions import (
     UserRuntimeException,
@@ -45,6 +44,9 @@
 )
 from cortex_internal.lib.concurrency import LockedFile
 from cortex_internal import consts
+from cortex_internal.lib.log import configure_logger
+
+logger = configure_logger("cortex", os.environ["CORTEX_LOG_CONFIG_FILE"])
 
 
 class ONNXClient:

pkg/cortex/serve/cortex_internal/lib/client/python.py

@@ -18,7 +18,6 @@
 import multiprocessing as mp
 from typing import Any, Optional, Callable
 
-from cortex_internal.lib.log import logger
 from cortex_internal.lib.exceptions import (
     UserRuntimeException,
     CortexException,
@@ -36,6 +35,9 @@
 )
 from cortex_internal.lib.concurrency import LockedFile
 from cortex_internal import consts
+from cortex_internal.lib.log import configure_logger
+
+logger = configure_logger("cortex", os.environ["CORTEX_LOG_CONFIG_FILE"])
 
 
 class PythonClient:

pkg/cortex/serve/cortex_internal/lib/client/tensorflow.py

@@ -32,8 +32,10 @@
     LockedModelsTree,
     get_models_from_api_spec,
 )
-from cortex_internal.lib.log import logger
 from cortex_internal import consts
+from cortex_internal.lib.log import configure_logger
+
+logger = configure_logger("cortex", os.environ["CORTEX_LOG_CONFIG_FILE"])
 
 
 class TensorFlowClient:

pkg/cortex/serve/cortex_internal/lib/log.py

@@ -19,6 +19,7 @@
 import http
 import datetime as dt
 import yaml
+import threading
 from pythonjsonlogger.jsonlogger import JsonFormatter
 
 
@@ -55,12 +56,17 @@ def format(self, record):
 
 
 logger = None
+_logger_initializer_mutex = threading.Lock()
 
 
 def configure_logger(name: str, config_file: str):
-    global logger
-    logger = retrieve_logger(name, config_file)
-    return logger
+    with _logger_initializer_mutex:
+        global logger
+        if logger is not None:
+            return logger
+
+        logger = retrieve_logger(name, config_file)
+        return logger
 
 
 def retrieve_logger(name: str, config_file: str):

pkg/cortex/serve/cortex_internal/lib/model/cron.py

@@ -26,7 +26,6 @@
 from typing import Dict, List, Tuple, Any, Union, Callable, Optional
 
 from cortex_internal.lib import util
-from cortex_internal.lib.log import logger
 from cortex_internal.lib.concurrency import LockedFile, get_locked_files
 from cortex_internal.lib.storage import S3, GCS
 from cortex_internal.lib.exceptions import CortexException, WithBreak
@@ -53,6 +52,9 @@
     ModelsTree,
     LockedModelsTree,
 )
+from cortex_internal.lib.log import configure_logger
+
+logger = configure_logger("cortex", os.environ["CORTEX_LOG_CONFIG_FILE"])
 
 
 class AbstractLoopingThread(td.Thread):

pkg/cortex/serve/cortex_internal/lib/model/model.py

@@ -19,10 +19,12 @@
 import threading as td
 from typing import Dict, List, Any, Tuple, Callable, AbstractSet, Optional
 
-from cortex_internal.lib.log import logger
 from cortex_internal.lib.concurrency import ReadWriteLock
 from cortex_internal.lib.exceptions import WithBreak, CortexException
 from cortex_internal.lib.type import PredictorType
+from cortex_internal.lib.log import configure_logger
+
+logger = configure_logger("cortex", os.environ["CORTEX_LOG_CONFIG_FILE"])
 
 
 class ModelsHolder:

pkg/cortex/serve/cortex_internal/lib/model/tfs.py

@@ -19,7 +19,10 @@
 from typing import Any, Optional, Dict, List, Tuple
 
 from cortex_internal.lib.exceptions import CortexException, UserException
-from cortex_internal.lib.log import logger
+from cortex_internal.lib.log import configure_logger
+
+logger = configure_logger("cortex", os.environ["CORTEX_LOG_CONFIG_FILE"])
+
 
 # TensorFlow types
 def _define_types() -> Tuple[Dict[str, Any], Dict[str, str]]: