Return nil when deployment fails (#1369)

Author: vishalbollu

cli/cmd/deploy.go

@@ -251,9 +251,7 @@ func mergeResultMessages(results []schema.DeployResult) string {
 		}
 	}
 
-	messages := append(okMessages, errMessages...)
-
-	return strings.Join(messages, "\n")
+	return strings.Join(okMessages, "\n") + "\n\n" + strings.Join(errMessages, "\n")
 }
 
 func didAllResultsError(results []schema.DeployResult) bool {
@@ -282,7 +280,10 @@ func getAPICommandsMessage(results []schema.DeployResult, envName string) string
 	items.Add(fmt.Sprintf("cortex get %s%s", apiName, envArg), "(show api info)")
 
 	for _, result := range results {
-		if result.API.Kind == userconfig.RealtimeAPIKind {
+		if len(result.Error) > 0 {
+			continue
+		}
+		if result.API.API != nil && result.API.Kind == userconfig.RealtimeAPIKind {
 			items.Add(fmt.Sprintf("cortex logs %s%s", apiName, envArg), "(stream api logs)")
 			break
 		}

cli/local/deploy.go

@@ -85,7 +85,7 @@ func Deploy(env cliconfig.Environment, configPath string, projectFileList []stri
 		if err != nil {
 			results[i].Error = errors.Message(err)
 		} else {
-			results[i].API = *api
+			results[i].API = api
 		}
 	}
 

pkg/operator/resources/resources.go

@@ -117,7 +117,7 @@ func Deploy(projectBytes []byte, configFileName string, configBytes []byte, forc
 		if err != nil {
 			results[i].Error = errors.Message(err)
 		} else {
-			results[i].API = *api
+			results[i].API = api
 		}
 	}
 

pkg/operator/schema/schema.go

@@ -47,7 +47,7 @@ type DeployResponse struct {
 }
 
 type DeployResult struct {
-	API     spec.API
+	API     *spec.API
 	Message string
 	Error   string
 }